RESOLVED WONTFIX 115340
DocumentOrderedMap should use AtomicString instead of AtomicStringImpl* 
https://bugs.webkit.org/show_bug.cgi?id=115340
Summary DocumentOrderedMap should use AtomicString instead of AtomicStringImpl*
Ryosuke Niwa
Reported 2013-04-28 17:53:22 PDT
Many member functions of DocumentOrderedMap take AtomicStringImpl* but they should take AtomicString instead. Furthermore, hash maps in DocumentOrderedMap could simply use AtomicString, instead of AtomicStringImpl*, as keys.
Attachments
Cleanup (8.28 KB, patch)
2013-04-28 17:54 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-04-28 17:54:03 PDT
Created attachment 199978 [details] Cleanup
Ryosuke Niwa
Comment 2 2013-04-28 19:17:00 PDT
Ben says this is intentional.
Darin Adler
Comment 3 2013-04-28 22:34:55 PDT
I think the reason we do it this way is that we don’t want additional ref/deref of all the strings.
Note You need to log in before you can comment on or make changes to this bug.