RESOLVED FIXED 115334
[WebKit2] Adopt new API for detecting window occlusion 
https://bugs.webkit.org/show_bug.cgi?id=115334
Summary [WebKit2] Adopt new API for detecting window occlusion
Sam Weinig
Reported 2013-04-28 13:17:35 PDT
[WebKit2] Adopt new API for detecting window occlusion
Attachments
Patch (15.68 KB, patch)
2013-04-28 13:21 PDT, Sam Weinig 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2013-04-28 13:21:25 PDT
Created attachment 199970 [details] Patch
Simon Fraser (smfr)
Comment 2 2013-04-28 13:25:16 PDT
Comment on attachment 199970 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199970&action=review > Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm:213 > +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090 > if ([m_wkView _isWindowOccluded]) > return false; > +#endif It would be slightly cleaner to have _isWindowOccluded pre-10.9 and just always return false.
Sam Weinig
Comment 3 2013-04-28 13:30:17 PDT
Committed r149260: <http://trac.webkit.org/changeset/149260>
Tim Horton
Comment 4 2013-05-01 01:57:32 PDT
Comment on attachment 199970 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199970&action=review > Source/WebKit2/UIProcess/API/mac/WKView.mm:-1893 > - [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(_windowWillOrderOffScreen:) > - name:@"NSWindowWillOrderOffScreenNotification" object:window]; Did you mean to remove the call to removeObserver for this notification as well?
Note You need to log in before you can comment on or make changes to this bug.