Bug 115325 - Remove Chromium code from Tools/BuildSlaveSupport
Summary: Remove Chromium code from Tools/BuildSlaveSupport
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-28 04:49 PDT by Zan Dobersek
Modified: 2013-04-28 23:51 PDT (History)
2 users (show)

See Also:

Attachments
Patch (12.47 KB, patch)
2013-04-28 05:00 PDT, Zan Dobersek 		benjamin: review+
benjamin: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-04-28 04:49:25 PDT 
Remove Chromium code from Tools/BuildSlaveSupport
Comment 1 Zan Dobersek 2013-04-28 05:00:54 PDT 
Created attachment 199963 [details]
Patch
Comment 2 Benjamin Poulain 2013-04-28 15:33:37 PDT 
Comment on attachment 199963 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199963&action=review

Gosh, we keep cleaning and you keep finding crap everywhere :(

> Tools/BuildSlaveSupport/built-product-archive:95
> -
> -    # Chromium bots may not have this directory
>      if not os.path.isdir(archiveDir):
>          os.mkdir(archiveDir)

Shouldn't the if go away?
If the comment is correct, it has become useless.
Comment 3 Ryosuke Niwa 2013-04-28 15:46:35 PDT 
Comment on attachment 199963 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199963&action=review

>> Tools/BuildSlaveSupport/built-product-archive:95
>>          os.mkdir(archiveDir)
> 
> Shouldn't the if go away?
> If the comment is correct, it has become useless.

Yup, we should get rid of it.

> Tools/BuildSlaveSupport/test-result-archive:-101
> -    zipper = zipfile.ZipFile(archiveFile, 'w', zipfile.ZIP_DEFLATED)

You can also remove zipfile from the import list.
Comment 4 Zan Dobersek 2013-04-28 23:50:18 PDT 
Committed r149270: <http://trac.webkit.org/changeset/149270>
Comment 5 Zan Dobersek 2013-04-28 23:51:20 PDT 
(In reply to comment #4)
> Committed r149270: <http://trac.webkit.org/changeset/149270>

... with all the comments addressed, thanks for the reviews.