Bug 115320 - Unifty the data access of StringImpl members from JavaScriptCore
Summary: Unifty the data access of StringImpl members from JavaScriptCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-27 22:24 PDT by Benjamin Poulain
Modified: 2013-04-29 18:22 PDT (History)
0 users

See Also:

Attachments
Patch (6.89 KB, patch)
2013-04-27 22:29 PDT, Benjamin Poulain 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2013-04-27 22:24:21 PDT 
Unifty the data access of StringImpl members from JavaScriptCore
Comment 1 Benjamin Poulain 2013-04-27 22:29:13 PDT 
Created attachment 199958 [details]
Patch
Comment 2 Andreas Kling 2013-04-29 06:39:11 PDT 
Comment on attachment 199958 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199958&action=review

Cute cleanup.

> Source/JavaScriptCore/ChangeLog:3
> +        Unifty the data access of StringImpl members from JavaScriptCore

Unifty -> Unify

> Source/JavaScriptCore/ChangeLog:9
> +        DFG access the member infos by directly calling the methods on StringImpl,
> +        while the baseline JIT was using helper methods on ThunkHelpers.

access -> accesses
Comment 3 Benjamin Poulain 2013-04-29 18:22:05 PDT 
Committed r149344: <http://trac.webkit.org/changeset/149344>