Bug 115319 - [WK2] Threads get stuck in NetworkProcess when canceling loads in WebProcess
Summary: [WK2] Threads get stuck in NetworkProcess when canceling loads in WebProcess
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-04-27 19:40 PDT by Alexey Proskuryakov
Modified: 2013-04-30 12:20 PDT (History)
3 users (show)

See Also:

Attachments
proposed fix (5.44 KB, patch)
2013-04-27 19:49 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
Patch v2 (12.31 KB, patch)
2013-04-30 10:11 PDT, Brady Eidson 		ap: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-04-27 19:40:53 PDT 
WebResourceLoader is not always correct when second-guessing whether to send a response to DidReceiveResponseWithCertificateInfo.

<rdar://problem/13757687>
Comment 1 Alexey Proskuryakov 2013-04-27 19:49:58 PDT 
Created attachment 199926 [details]
proposed fix
Comment 2 WebKit Commit Bot 2013-04-27 20:21:56 PDT 
Comment on attachment 199926 [details]
proposed fix

Clearing flags on attachment: 199926

Committed r149251: <http://trac.webkit.org/changeset/149251>
Comment 3 WebKit Commit Bot 2013-04-27 20:21:58 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Brady Eidson 2013-04-29 09:50:35 PDT 
This re-introduced the crashed fixed in https://bugs.webkit.org/show_bug.cgi?id=115061

Also:
"...alrady canceled..." ?  :)
Comment 5 Alexey Proskuryakov 2013-04-29 11:10:52 PDT 
Sadly, this means that the bug is much harder to fix - the null check being necessary means that we can't send messages back.

Re-added the null check in <http://trac.webkit.org/r149298>.
Comment 6 Brady Eidson 2013-04-30 10:11:48 PDT 
Created attachment 200126 [details]
Patch v2

This patch was originally written by Alexey, reviewed by me, then tweaked and tested heavily by me... so I'll give him a chance to review back!
Comment 7 Alexey Proskuryakov 2013-04-30 10:15:24 PDT 
Comment on attachment 200126 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=200126&action=review

> Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp:112
> +    // If m_coreLoader becomse null as a result of the didReceiveResponse callback, we can't use the send function(). 

Typo: becomse
Comment 8 Brady Eidson 2013-04-30 12:20:29 PDT 
http://trac.webkit.org/changeset/149389