Bug 115313 - Get rid of StorageTask
Summary: Get rid of StorageTask
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-27 14:06 PDT by Anders Carlsson
Modified: 2013-04-29 11:05 PDT (History)
12 users (show)

See Also:


Attachments
Patch (18.37 KB, patch)
2013-04-27 14:07 PDT, Anders Carlsson
no flags Details | Formatted Diff | Diff
Patch (18.32 KB, patch)
2013-04-29 10:12 PDT, Anders Carlsson
no flags Details | Formatted Diff | Diff
Patch (18.52 KB, patch)
2013-04-29 10:37 PDT, Anders Carlsson
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-04-27 14:06:16 PDT
Get rid of StorageTask
Comment 1 Anders Carlsson 2013-04-27 14:07:28 PDT
Created attachment 199916 [details]
Patch
Comment 2 WebKit Commit Bot 2013-04-27 14:13:10 PDT
Attachment 199916 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/storage/StorageSyncManager.cpp', u'Source/WebCore/storage/StorageTask.cpp', u'Source/WebCore/storage/StorageTask.h', u'Source/WebCore/storage/StorageThread.cpp', u'Source/WebCore/storage/StorageThread.h', u'Source/WebCore/storage/StorageTracker.cpp']" exit_code: 1
Source/WebCore/storage/StorageThread.cpp:78:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebCore/storage/StorageThread.cpp:84:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebCore/storage/StorageThread.h:65:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 3 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2013-04-27 14:16:47 PDT
Comment on attachment 199916 [details]
Patch

Attachment 199916 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/221054
Comment 4 Early Warning System Bot 2013-04-27 14:18:26 PDT
Comment on attachment 199916 [details]
Patch

Attachment 199916 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/187339
Comment 5 EFL EWS Bot 2013-04-27 14:24:23 PDT
Comment on attachment 199916 [details]
Patch

Attachment 199916 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/169284
Comment 6 EFL EWS Bot 2013-04-27 14:30:21 PDT
Comment on attachment 199916 [details]
Patch

Attachment 199916 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/12265
Comment 7 Build Bot 2013-04-27 14:35:53 PDT
Comment on attachment 199916 [details]
Patch

Attachment 199916 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/47710
Comment 8 Build Bot 2013-04-27 14:51:38 PDT
Comment on attachment 199916 [details]
Patch

Attachment 199916 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/131432
Comment 9 kov's GTK+ EWS bot 2013-04-27 14:59:12 PDT
Comment on attachment 199916 [details]
Patch

Attachment 199916 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/221060
Comment 10 Build Bot 2013-04-27 21:39:09 PDT
Comment on attachment 199916 [details]
Patch

Attachment 199916 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/238118
Comment 11 Anders Carlsson 2013-04-29 10:12:29 PDT
Created attachment 200023 [details]
Patch
Comment 12 WebKit Commit Bot 2013-04-29 10:13:23 PDT
Attachment 200023 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/storage/StorageSyncManager.cpp', u'Source/WebCore/storage/StorageTask.cpp', u'Source/WebCore/storage/StorageTask.h', u'Source/WebCore/storage/StorageThread.cpp', u'Source/WebCore/storage/StorageThread.h', u'Source/WebCore/storage/StorageTracker.cpp']" exit_code: 1
Source/WebCore/storage/StorageThread.cpp:78:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebCore/storage/StorageThread.cpp:84:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebCore/storage/StorageThread.h:65:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 3 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 13 EFL EWS Bot 2013-04-29 10:35:53 PDT
Comment on attachment 200023 [details]
Patch

Attachment 200023 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/229545
Comment 14 Build Bot 2013-04-29 10:36:19 PDT
Comment on attachment 200023 [details]
Patch

Attachment 200023 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/195734
Comment 15 Anders Carlsson 2013-04-29 10:37:18 PDT
Created attachment 200024 [details]
Patch
Comment 16 WebKit Commit Bot 2013-04-29 10:38:44 PDT
Attachment 200024 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/storage/StorageSyncManager.cpp', u'Source/WebCore/storage/StorageTask.cpp', u'Source/WebCore/storage/StorageTask.h', u'Source/WebCore/storage/StorageThread.cpp', u'Source/WebCore/storage/StorageThread.h', u'Source/WebCore/storage/StorageTracker.cpp']" exit_code: 1
Source/WebCore/storage/StorageThread.cpp:78:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebCore/storage/StorageThread.cpp:84:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebCore/storage/StorageThread.h:65:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 3 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 17 Andreas Kling 2013-04-29 11:04:06 PDT
Comment on attachment 200024 [details]
Patch

r=me
Comment 18 Anders Carlsson 2013-04-29 11:05:25 PDT
Committed r149297: <http://trac.webkit.org/changeset/149297>