WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
115313
Get rid of StorageTask
https://bugs.webkit.org/show_bug.cgi?id=115313
Summary
Get rid of StorageTask
Anders Carlsson
Reported
2013-04-27 14:06:16 PDT
Get rid of StorageTask
Attachments
Patch
(18.37 KB, patch)
2013-04-27 14:07 PDT
,
Anders Carlsson
no flags
Details
Formatted Diff
Diff
Patch
(18.32 KB, patch)
2013-04-29 10:12 PDT
,
Anders Carlsson
no flags
Details
Formatted Diff
Diff
Patch
(18.52 KB, patch)
2013-04-29 10:37 PDT
,
Anders Carlsson
kling
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2013-04-27 14:07:28 PDT
Created
attachment 199916
[details]
Patch
WebKit Commit Bot
Comment 2
2013-04-27 14:13:10 PDT
Attachment 199916
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/storage/StorageSyncManager.cpp', u'Source/WebCore/storage/StorageTask.cpp', u'Source/WebCore/storage/StorageTask.h', u'Source/WebCore/storage/StorageThread.cpp', u'Source/WebCore/storage/StorageThread.h', u'Source/WebCore/storage/StorageTracker.cpp']" exit_code: 1 Source/WebCore/storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4] Source/WebCore/storage/StorageThread.cpp:84: Extra space before ( in function call [whitespace/parens] [4] Source/WebCore/storage/StorageThread.h:65: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 3
2013-04-27 14:16:47 PDT
Comment on
attachment 199916
[details]
Patch
Attachment 199916
[details]
did not pass qt-ews (qt): Output:
http://webkit-queues.appspot.com/results/221054
Early Warning System Bot
Comment 4
2013-04-27 14:18:26 PDT
Comment on
attachment 199916
[details]
Patch
Attachment 199916
[details]
did not pass qt-wk2-ews (qt-wk2): Output:
http://webkit-queues.appspot.com/results/187339
EFL EWS Bot
Comment 5
2013-04-27 14:24:23 PDT
Comment on
attachment 199916
[details]
Patch
Attachment 199916
[details]
did not pass efl-wk2-ews (efl-wk2): Output:
http://webkit-queues.appspot.com/results/169284
EFL EWS Bot
Comment 6
2013-04-27 14:30:21 PDT
Comment on
attachment 199916
[details]
Patch
Attachment 199916
[details]
did not pass efl-ews (efl): Output:
http://webkit-queues.appspot.com/results/12265
Build Bot
Comment 7
2013-04-27 14:35:53 PDT
Comment on
attachment 199916
[details]
Patch
Attachment 199916
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.appspot.com/results/47710
Build Bot
Comment 8
2013-04-27 14:51:38 PDT
Comment on
attachment 199916
[details]
Patch
Attachment 199916
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.appspot.com/results/131432
kov's GTK+ EWS bot
Comment 9
2013-04-27 14:59:12 PDT
Comment on
attachment 199916
[details]
Patch
Attachment 199916
[details]
did not pass gtk-ews (gtk): Output:
http://webkit-queues.appspot.com/results/221060
Build Bot
Comment 10
2013-04-27 21:39:09 PDT
Comment on
attachment 199916
[details]
Patch
Attachment 199916
[details]
did not pass win-ews (win): Output:
http://webkit-queues.appspot.com/results/238118
Anders Carlsson
Comment 11
2013-04-29 10:12:29 PDT
Created
attachment 200023
[details]
Patch
WebKit Commit Bot
Comment 12
2013-04-29 10:13:23 PDT
Attachment 200023
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/storage/StorageSyncManager.cpp', u'Source/WebCore/storage/StorageTask.cpp', u'Source/WebCore/storage/StorageTask.h', u'Source/WebCore/storage/StorageThread.cpp', u'Source/WebCore/storage/StorageThread.h', u'Source/WebCore/storage/StorageTracker.cpp']" exit_code: 1 Source/WebCore/storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4] Source/WebCore/storage/StorageThread.cpp:84: Extra space before ( in function call [whitespace/parens] [4] Source/WebCore/storage/StorageThread.h:65: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
EFL EWS Bot
Comment 13
2013-04-29 10:35:53 PDT
Comment on
attachment 200023
[details]
Patch
Attachment 200023
[details]
did not pass efl-wk2-ews (efl-wk2): Output:
http://webkit-queues.appspot.com/results/229545
Build Bot
Comment 14
2013-04-29 10:36:19 PDT
Comment on
attachment 200023
[details]
Patch
Attachment 200023
[details]
did not pass win-ews (win): Output:
http://webkit-queues.appspot.com/results/195734
Anders Carlsson
Comment 15
2013-04-29 10:37:18 PDT
Created
attachment 200024
[details]
Patch
WebKit Commit Bot
Comment 16
2013-04-29 10:38:44 PDT
Attachment 200024
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/storage/StorageSyncManager.cpp', u'Source/WebCore/storage/StorageTask.cpp', u'Source/WebCore/storage/StorageTask.h', u'Source/WebCore/storage/StorageThread.cpp', u'Source/WebCore/storage/StorageThread.h', u'Source/WebCore/storage/StorageTracker.cpp']" exit_code: 1 Source/WebCore/storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4] Source/WebCore/storage/StorageThread.cpp:84: Extra space before ( in function call [whitespace/parens] [4] Source/WebCore/storage/StorageThread.h:65: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 17
2013-04-29 11:04:06 PDT
Comment on
attachment 200024
[details]
Patch r=me
Anders Carlsson
Comment 18
2013-04-29 11:05:25 PDT
Committed
r149297
: <
http://trac.webkit.org/changeset/149297
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug