Bug 115309 - Replace uses of StorageTask with StorageThread::dispatch and WTF::bind
Summary: Replace uses of StorageTask with StorageThread::dispatch and WTF::bind
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-27 13:07 PDT by Anders Carlsson
Modified: 2013-04-27 13:27 PDT (History)
0 users

See Also:


Attachments
Patch (10.45 KB, patch)
2013-04-27 13:07 PDT, Anders Carlsson
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-04-27 13:07:11 PDT
Replace uses of StorageTask with StorageThread::dispatch and WTF::bind
Comment 1 Anders Carlsson 2013-04-27 13:07:51 PDT
Created attachment 199910 [details]
Patch
Comment 2 Andreas Kling 2013-04-27 13:25:24 PDT
Comment on attachment 199910 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199910&action=review

r=me

> Source/WebCore/storage/StorageTask.cpp:94
>              break;

This line should also be removed.

> Source/WebCore/storage/StorageTracker.cpp:391
> +    m_thread->dispatch(bind(&StorageTracker::syncDeleteAllOrigins, this));

Dispatching a "sync" method sure looks odd.
Comment 3 Anders Carlsson 2013-04-27 13:27:27 PDT
Committed r149242: <http://trac.webkit.org/changeset/149242>