buttons with aria-pressed value matching "true", "false", or "mixed" should be exposed as AXCheckbox:AXToggleButton, with role description of "toggle button" aria-pressed values of false, true, and mixed should be exposed as AXValue: 0, 1, and 2, respectively. Any other aria-pressed value (e.g. "", "undefined", "foo", etc.) should cause the role to be exposed as a standard AXButton.
<rdar://problem/13635355>
Created attachment 230228 [details] test case
Created attachment 249453 [details] patch
It didn't even take 2 years! the system works!
Attachment 249453 [details] did not pass style-queue: ERROR: Source/WebCore/accessibility/AccessibilityObject.cpp:2232: aria_pressed is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 249454 [details] style fix patch
Comment on attachment 249454 [details] style fix patch Attachment 249454 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6186148426678272 New failing tests: platform/mac/accessibility/aria-pressed-button-attributes.html
Created attachment 249458 [details] Archive of layout-test-results from ews100 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 249454 [details] style fix patch Attachment 249454 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4710484636860416 New failing tests: platform/mac/accessibility/aria-pressed-button-attributes.html
Created attachment 249461 [details] Archive of layout-test-results from ews107 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 249478 [details] patch
Comment on attachment 249478 [details] patch (In reply to comment #4) > It didn't even take 2 years! the system works! Just in time!
Comment on attachment 249478 [details] patch Clearing flags on attachment: 249478 Committed r182012: <http://trac.webkit.org/changeset/182012>
All reviewed patches have been landed. Closing bug.
This broke Windows tests. Can you review and correct the problem? Otherwise I will roll out.
Comment on attachment 249478 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=249478&action=review > LayoutTests/platform/mac/accessibility/aria-toggle-button-with-title-expected.txt:11 > +Role: AXRole: AXCheckBox This broke Windows tests because you did not provide a Windows test expectation. Likewise, the EFL and GTK tests are failing because they have no test expectation.
Yes I'll take a look
Corrected test expectations committed in r182075 <http://trac.webkit.org/changeset/182075>.
Thanks for handling Brent (In reply to comment #18) > Corrected test expectations committed in r182075 > <http://trac.webkit.org/changeset/182075>.
Very grateful that this is now apparently fixed !