RESOLVED FIXED 115297
fourthTier: ASSERT that commonly used not-thread-safe methods in the runtime are not being called during compilation 
https://bugs.webkit.org/show_bug.cgi?id=115297
Summary fourthTier: ASSERT that commonly used not-thread-safe methods in the runtime ...
Filip Pizlo
Reported 2013-04-26 20:47:45 PDT
We have a bunch of methods that we traditionally did call during compilation, like WatchpointSet::isStillValid() and Structure::get(). At least for those methods, we should add asserts that check that they are not being called during compilation. In a serial compilation mode, we should set a thread-local to denote start/end of compilation; in a concurrent compilation mode, we should check that we aren't in the compiler thread.
Attachments
the patch (47.39 KB, patch)
2013-04-28 18:47 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-04-28 18:47:54 PDT
Created attachment 199979 [details] the patch
Geoffrey Garen
Comment 2 2013-04-28 21:12:00 PDT
Comment on attachment 199979 [details] the patch r=me
Filip Pizlo
Comment 3 2013-04-29 11:31:05 PDT
Landed in http://trac.webkit.org/changeset/149301
Note You need to log in before you can comment on or make changes to this bug.