Bug 115297 - fourthTier: ASSERT that commonly used not-thread-safe methods in the runtime are not being called during compilation
Summary: fourthTier: ASSERT that commonly used not-thread-safe methods in the runtime ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 112839
  Show dependency treegraph
 
Reported: 2013-04-26 20:47 PDT by Filip Pizlo
Modified: 2013-04-29 11:31 PDT (History)
7 users (show)

See Also:


Attachments
the patch (47.39 KB, patch)
2013-04-28 18:47 PDT, Filip Pizlo
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-04-26 20:47:45 PDT
We have a bunch of methods that we traditionally did call during compilation, like WatchpointSet::isStillValid() and Structure::get().  At least for those methods, we should add asserts that check that they are not being called during compilation.  In a serial compilation mode, we should set a thread-local to denote start/end of compilation; in a concurrent compilation mode, we should check that we aren't in the compiler thread.
Comment 1 Filip Pizlo 2013-04-28 18:47:54 PDT
Created attachment 199979 [details]
the patch
Comment 2 Geoffrey Garen 2013-04-28 21:12:00 PDT
Comment on attachment 199979 [details]
the patch

r=me
Comment 3 Filip Pizlo 2013-04-29 11:31:05 PDT
Landed in http://trac.webkit.org/changeset/149301