Bug 115288 - REGRESSION: We see authentication challenge sheets for favicon requests
Summary: REGRESSION: We see authentication challenge sheets for favicon requests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-04-26 16:33 PDT by Brady Eidson
Modified: 2013-04-29 12:06 PDT (History)
3 users (show)

See Also:

Attachments
Patch v1 (16.90 KB, patch)
2013-04-26 17:05 PDT, Brady Eidson 		ap: review+
Details | Formatted Diff | Diff
Patch v2 - Actually works... (34.78 KB, patch)
2013-04-29 11:37 PDT, Brady Eidson 		ap: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2013-04-26 16:33:47 PDT 
REGRESSION: We see authentication challenge sheets for favicon requests

This regressed when the NetworkProcess started sending auth challenges directly to the UI process.

<rdar://problem/13753470>
Comment 1 Brady Eidson 2013-04-26 16:55:01 PDT 
In fact, there's a much greater regression here that I filed in https://bugs.webkit.org/show_bug.cgi?id=115291

But the favicon case should still be fixed separately.
Comment 2 Brady Eidson 2013-04-26 17:05:36 PDT 
Created attachment 199875 [details]
Patch v1
Comment 3 Alexey Proskuryakov 2013-04-26 22:36:21 PDT 
Comment on attachment 199875 [details]
Patch v1

Nice!
Comment 4 Brady Eidson 2013-04-29 11:36:46 PDT 
Actually that patch was too simple, and wrong - uninitialized member variable... in testing it appeared to work through straight up luck.

Full fix is a bit more invasive in touching more parts of the code, but is still pretty mechanical.
Comment 5 Brady Eidson 2013-04-29 11:37:02 PDT 
Created attachment 200034 [details]
Patch v2 - Actually works...
Comment 6 WebKit Commit Bot 2013-04-29 11:38:59 PDT 
Attachment 200034 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/loader/DocumentLoader.cpp', u'Source/WebCore/loader/DocumentThreadableLoader.cpp', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/loader/FrameLoader.h', u'Source/WebCore/loader/LoaderStrategy.cpp', u'Source/WebCore/loader/LoaderStrategy.h', u'Source/WebCore/loader/NetscapePlugInStreamLoader.cpp', u'Source/WebCore/loader/ResourceLoader.cpp', u'Source/WebCore/loader/ResourceLoader.h', u'Source/WebCore/loader/ResourceLoaderOptions.h', u'Source/WebCore/loader/cache/CachedResourceLoader.cpp', u'Source/WebCore/loader/icon/IconLoader.cpp', u'Source/WebCore/platform/network/ResourceHandleTypes.h', u'Source/WebCore/xml/XSLTProcessorLibxslt.cpp', u'Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/NetworkProcess/NetworkProcessPlatformStrategies.cpp', u'Source/WebKit2/NetworkProcess/NetworkProcessPlatformStrategies.h', u'Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp', u'Source/WebKit2/NetworkProcess/NetworkResourceLoader.h', u'Source/WebKit2/NetworkProcess/SchedulableLoader.cpp', u'Source/WebKit2/NetworkProcess/SchedulableLoader.h', u'Source/WebKit2/Shared/Network/NetworkResourceLoadParameters.cpp', u'Source/WebKit2/Shared/Network/NetworkResourceLoadParameters.h', u'Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.h']" exit_code: 1
Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:229:  Missing space after ,  [whitespace/comma] [3]
Total errors found: 1 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Brady Eidson 2013-04-29 12:06:58 PDT 
http://trac.webkit.org/changeset/149303