Bug 115287 - ~BlockAllocator should ASSERT that it has no more Regions left
Summary: ~BlockAllocator should ASSERT that it has no more Regions left
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-26 16:19 PDT by Mark Hahnenberg
Modified: 2013-04-29 12:51 PDT (History)
0 users

See Also:

Attachments
Patch (2.42 KB, patch)
2013-04-26 17:23 PDT, Mark Hahnenberg 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2013-04-26 16:19:42 PDT 
Title says it all.
Comment 1 Mark Hahnenberg 2013-04-26 17:23:09 PDT 
Created attachment 199879 [details]
Patch
Comment 2 Andreas Kling 2013-04-27 09:52:51 PDT 
Comment on attachment 199879 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199879&action=review

r=me

> Source/JavaScriptCore/heap/BlockAllocator.cpp:61
> +    ASSERT(allRegionSetsAreEmpty() && m_emptyRegions.isEmpty());

You could make this two separate ASSERTs so it's easy to see which one is failing.

> Source/JavaScriptCore/heap/BlockAllocator.h:75
> +        bool isEmpty()

I'd make this const.

> Source/JavaScriptCore/heap/BlockAllocator.h:88
> +    bool allRegionSetsAreEmpty();

Ditto.
Comment 3 Mark Hahnenberg 2013-04-29 12:51:19 PDT 
Committed r149305: <http://trac.webkit.org/changeset/149305>