Bug 115284 - [BlackBerry] Update HTML5 progress bar UX
Summary: [BlackBerry] Update HTML5 progress bar UX
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-26 15:44 PDT by Tiancheng Jiang
Modified: 2013-05-06 12:12 PDT (History)
4 users (show)

See Also:

Attachments
Patch (10.12 KB, patch)
2013-04-26 15:51 PDT, Tiancheng Jiang 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (1.63 MB, application/zip)
2013-04-26 17:57 PDT, Build Bot 		no flags Details
Patch (12.39 KB, patch)
2013-05-06 11:32 PDT, Tiancheng Jiang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tiancheng Jiang 2013-04-26 15:44:23 PDT 
Use GL render method to paint progress bar.
Comment 1 Tiancheng Jiang 2013-04-26 15:51:56 PDT 
Created attachment 199868 [details]
Patch
Comment 2 Build Bot 2013-04-26 17:57:29 PDT 
Comment on attachment 199868 [details]
Patch

Attachment 199868 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/42711

New failing tests:
fast/frames/crash-remove-iframe-during-object-beforeload.html
Comment 3 Build Bot 2013-04-26 17:57:30 PDT 
Created attachment 199881 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.2
Comment 4 Jeff Rogers 2013-04-27 17:14:33 PDT 
You will need to update this patch as it looks like you reintroduced the old logic for painting the slider track and a whole bunch of obsolete constants. This patch should only be adding the new progress bar logic.
Comment 5 Tiancheng Jiang 2013-04-29 07:51:01 PDT 
This is just a revert patch and I have the real patch coming. But I am not sure how could this patch break the DRT test.

(In reply to comment #4)
> You will need to update this patch as it looks like you reintroduced the old logic for painting the slider track and a whole bunch of obsolete constants. This patch should only be adding the new progress bar logic.
Comment 6 Rob Buis 2013-05-06 10:32:57 PDT 
Comment on attachment 199868 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199868&action=review

Please remove the Skia block.

> Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:751
> +#if USE(SKIA)

I don't think you want to add SKIA specific code anymore.
Comment 7 Rob Buis 2013-05-06 10:38:26 PDT 
Comment on attachment 199868 [details]
Patch

It turns out the SKIA block is temporary, so this can go in.
Comment 8 WebKit Commit Bot 2013-05-06 11:04:49 PDT 
Comment on attachment 199868 [details]
Patch

Clearing flags on attachment: 199868

Committed r149614: <http://trac.webkit.org/changeset/149614>
Comment 9 WebKit Commit Bot 2013-05-06 11:04:51 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Tiancheng Jiang 2013-05-06 11:32:27 PDT 
Reopening to attach new patch.
Comment 11 Tiancheng Jiang 2013-05-06 11:32:30 PDT 
Created attachment 200728 [details]
Patch
Comment 12 Rob Buis 2013-05-06 11:44:46 PDT 
Comment on attachment 200728 [details]
Patch

Ok.
Comment 13 WebKit Commit Bot 2013-05-06 12:12:44 PDT 
Comment on attachment 200728 [details]
Patch

Clearing flags on attachment: 200728

Committed r149624: <http://trac.webkit.org/changeset/149624>
Comment 14 WebKit Commit Bot 2013-05-06 12:12:47 PDT 
All reviewed patches have been landed.  Closing bug.