Bug 115274 - [WK2] testRunner.setPrivateBrowsingEnabled doesn't work with NetworkProcess
Summary: [WK2] testRunner.setPrivateBrowsingEnabled doesn't work with NetworkProcess
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: LayoutTestFailure
Depends on:
Blocks:
 
Reported: 2013-04-26 13:22 PDT by Alexey Proskuryakov
Modified: 2016-03-03 13:25 PST (History)
4 users (show)

See Also:

Attachments
Patch (6.55 KB, patch)
2016-03-03 11:30 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-04-26 13:22:59 PDT 
InjectedBundle::setPrivateBrowsingEnabled only enables private browsing in WebProcess, not in NetworkProcess.

One complication here is that we need to go through UI process - letting WebProcess directly change private browsing settings in NetworkProcess would be undesirable for security.
Comment 1 Alex Christensen 2016-03-03 11:30:17 PST 
Created attachment 272766 [details]
Patch
Comment 2 WebKit Commit Bot 2016-03-03 13:25:01 PST 
Comment on attachment 272766 [details]
Patch

Clearing flags on attachment: 272766

Committed r197516: <http://trac.webkit.org/changeset/197516>
Comment 3 WebKit Commit Bot 2016-03-03 13:25:05 PST 
All reviewed patches have been landed.  Closing bug.