Bug 115270 – [WKTR] Tests dumping audio data shouldn't dump pixels

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Zan Dobersek]

[WKTR] Tests dumping audio data shouldn't dump pixels

[Zan Dobersek]

Created attachment 199850 [details]
Patch

[Build Bot]

Comment on attachment 199850 [details]
Patch

Attachment 199850 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/214121

New failing tests:
fast/frames/crash-remove-iframe-during-object-beforeload.html

[Build Bot]

Created attachment 199854 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2

[Benjamin Poulain]

Comment on attachment 199850 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199850&action=review

> Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:383
>      WKRetainPtr<WKDataRef> audioData(AdoptWK, WKBundleCreateWKDataFromUInt8Array(InjectedBundle::shared().bundle(), context, data));
>      InjectedBundle::shared().setAudioResult(audioData.get());
>      m_whatToDump = Audio;
> +    m_dumpPixels = false;

Maybe rename setAudioData to setAudioResult?

[Zan Dobersek]

Comment on attachment 199850 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199850&action=review

>> Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:383
>> +    m_dumpPixels = false;
> 
> Maybe rename setAudioData to setAudioResult?

Sounds better. I'll do that in a separate patch.

[Zan Dobersek]

Comment on attachment 199850 [details]
Patch

Clearing flags on attachment: 199850

Committed r149258: <http://trac.webkit.org/changeset/149258>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.