Bug 115266 – RenderMeter::valueRatio() is private

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Daker Fernandes Pinheiro]

This function is currently unused.
However, it is necessary to implement a RenderTheme capable of rendering Meter elements.

[Daker Fernandes Pinheiro]

Created attachment 199845 [details]
Change method visibility

[Jesus Sanchez-Palencia]

Comment on attachment 199845 [details]
Change method visibility

View in context: https://bugs.webkit.org/attachment.cgi?id=199845&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests.

You should specify the reason why no new tests were needed (e.g.: "No new tests, no behavior was changed").

> Source/WebCore/rendering/RenderMeter.h:41
> +    double valueRatio() const;

Why do you need it to public? A 1-line explanation in Changelog should be enough. :)

[Daker Fernandes Pinheiro]

Created attachment 199846 [details]
Change method visibility with fixed ChangeLog

[WebKit Commit Bot]

Comment on attachment 199846 [details]
Change method visibility with fixed ChangeLog

Clearing flags on attachment: 199846

Committed r149203: <http://trac.webkit.org/changeset/149203>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Benjamin Poulain]

What?
Please explain this change.

I could understand for <progress> but for <meter> the rendering depends on the gaugeRegion and you cannot access that from the renderer.
You must access the MeterElement to style the element correctly, and have all styling parameters available there.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 115343

[Daker Fernandes Pinheiro]

I also though strange that it is a private method and no one was using it.
It looked to me like a forgotten piece of code.

I was using the valueRatio because is a simplest way to paint
a minimal meter element, since it already does the ratio math.

Since it looked like RenderProgress position parameter, I made it public to use it in my own style.

Since it is not used anywhere, shouldn't it be deleted?

[Daker Fernandes Pinheiro]

Created attachment 200025 [details]
Remove unused method RenderMeter::valueRatio()

[WebKit Commit Bot]

Comment on attachment 200025 [details]
Remove unused method RenderMeter::valueRatio()

Clearing flags on attachment: 200025

Committed r149308: <http://trac.webkit.org/changeset/149308>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.