RESOLVED FIXED 115263
Remove all remaining Skia code
https://bugs.webkit.org/show_bug.cgi?id=115263
Summary Remove all remaining Skia code
Alberto Garcia
Reported 2013-04-26 09:37:51 PDT
Most Skia code was removed after bug 114886 was fixed, but there's still a couple of files and a few references to Skia in several places that can be removed. I'll take care of those.
Attachments
Patch (38.56 KB, patch)
2013-04-29 13:26 PDT, Alberto Garcia
no flags
Alberto Garcia
Comment 1 2013-04-29 13:26:31 PDT
Created attachment 200042 [details] Patch This patch removes almost all remaining references to Skia. A couple of comments: - FrameLoaderClientBlackBerry.cpp still contains some Skia code, but I'm not removing it now. Soon I'll upstream the most recent version of that file, which is significantly different from this one. - I didn't remove LayoutTests/fast/canvas/canvas-skia-excessive-size. This test checks whether the browser can handle the creation of an excessively large canvas, which sounds like a useful test in general. Maybe we can rename it? - Other Skia tests: svg/custom/image-rescale-clip.html svg/custom/image-rescale-scroll.html These come from bug 42370, "Scaled Resized images are blurred when sent to Skia". I didn't touch them in this patch, but I'm not sure if they are really interesting to keep.
Benjamin Poulain
Comment 2 2013-04-29 18:28:54 PDT
Comment on attachment 200042 [details] Patch Awesome!
WebKit Commit Bot
Comment 3 2013-04-29 18:59:03 PDT
Comment on attachment 200042 [details] Patch Clearing flags on attachment: 200042 Committed r149347: <http://trac.webkit.org/changeset/149347>
WebKit Commit Bot
Comment 4 2013-04-29 18:59:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.