Bug 115260 - Web Inspector: support frame instrumentation for coordinated graphics
Summary: Web Inspector: support frame instrumentation for coordinated graphics
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Roland Takacs
URL:
Keywords:
Depends on:
Blocks: 88225
  Show dependency treegraph
 
Reported: 2013-04-26 07:57 PDT by Noam Rosenthal
Modified: 2013-05-23 02:38 PDT (History)
14 users (show)

See Also:


Attachments
patch (3.39 KB, patch)
2013-05-21 04:56 PDT, Roland Takacs
kling: review+
kling: commit-queue-
Details | Formatted Diff | Diff
patch (3.39 KB, patch)
2013-05-23 02:03 PDT, Roland Takacs
rtakacs: commit-queue?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2013-04-26 07:57:39 PDT
Currently frame instrumentation only works for Blackberry (and for Chromium in Blink)
We need to support it in coordinated graphics for Qt/EFL, by calling the right functions from CoordinatedLayerTreeHost and enabling the flag.
Comment 1 Roland Takacs 2013-05-21 04:56:47 PDT
Created attachment 202413 [details]
patch

Overrode supportsFrameInstrumentation in order to enable frame instrumentation on ports that use coordinated graphics.
didBeginFrame() needs to be called to render bars.
Comment 2 Noam Rosenthal 2013-05-21 05:00:04 PDT
Comment on attachment 202413 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202413&action=review

LGTM, but needs owner review as it touches common WebKit2 files.

> Source/WebKit2/ChangeLog:9
> +        when didBeginFrame() is called.

you mean "by calling didBeginFrame()"
Comment 3 Andreas Kling 2013-05-22 11:23:57 PDT
Comment on attachment 202413 [details]
patch

o=me
Comment 4 Roland Takacs 2013-05-23 02:03:49 PDT
Created attachment 202650 [details]
patch
Comment 5 Ádám Kallai 2013-05-23 02:37:35 PDT
Landed: http://trac.webkit.org/changeset/150578