RESOLVED INVALID 115257
Remove duplicated null check in DocumentWriter::end() 
https://bugs.webkit.org/show_bug.cgi?id=115257
Summary Remove duplicated null check in DocumentWriter::end()
Kangil Han
Reported 2013-04-26 07:01:40 PDT
DocumentWriter::end() has duplicated null check, so delete it.
Attachments
Patch (1.25 KB, patch)
2013-04-26 07:03 PDT, Kangil Han 		darin: review-
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (705.27 KB, application/zip)
2013-04-26 07:35 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Kangil Han
Comment 1 2013-04-26 07:03:22 PDT
Created attachment 199828 [details] Patch
Build Bot
Comment 2 2013-04-26 07:35:01 PDT
Comment on attachment 199828 [details] Patch Attachment 199828 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/38698 New failing tests: fast/frames/set-parent-src-synchronously.xhtml fast/parser/iframe-sets-parent-to-javascript-url.html
Build Bot
Comment 3 2013-04-26 07:35:03 PDT
Created attachment 199833 [details] Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.2
Andreas Kling
Comment 4 2013-04-26 07:40:11 PDT
Comment on attachment 199828 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199828&action=review > Source/WebCore/loader/DocumentWriter.cpp:-247 > m_parser->flush(this); > - if (!m_parser) > - return; Are you sure m_parser can't get nulled out below flush()?
Darin Adler
Comment 5 2013-04-26 08:19:08 PDT
Comment on attachment 199828 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199828&action=review >> Source/WebCore/loader/DocumentWriter.cpp:-247 >> - return; > > Are you sure m_parser can't get nulled out below flush()? It seems to me that it could. I don’t think this change is correct.
Note You need to log in before you can comment on or make changes to this bug.