Bug 115256 – Use the complete block as the context for Dictionary lookups

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Thomas Deniau]

Use the complete block as the context for Dictionary lookups

[Thomas Deniau]

Created attachment 199826 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/13747883>

[Thomas Deniau]

When computing the context we give when looking up a word in the Dictionary, use startOfBlock/endOfBlock instead of startOfParagraph/endOfParagraph so that the context doesn't stop at line breaks.

[Ryosuke Niwa]

Comment on attachment 199826 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199826&action=review

> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:510
> +    // A "paragraph" is not enough as it may stop at a <br> and Lookup sometimes needs several lines of context.

If paragraph isn’t good enough, then block is probably not good enough either.
You realize that we can have each paragraph being isolated by a div, right?

[Thomas Deniau]

Comment on attachment 199826 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199826&action=review

>> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:510
>> +    // A "paragraph" is not enough as it may stop at a <br> and Lookup sometimes needs several lines of context.
> 
> If paragraph isn’t good enough, then block is probably not good enough either.
> You realize that we can have each paragraph being isolated by a div, right?

I do. This is of course best-effort and there's no solution that can work with all the web pages out there. My take is that a good Web author will put any related information (that Lookup cares about) in the same block. If that doesn't work, Lookup will do its best given the partial context. The user can select text manually if that's not enough...

[Ryosuke Niwa]

Comment on attachment 199826 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199826&action=review

>>> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:510
>>> +    // A "paragraph" is not enough as it may stop at a <br> and Lookup sometimes needs several lines of context.
>> 
>> If paragraph isn’t good enough, then block is probably not good enough either.
>> You realize that we can have each paragraph being isolated by a div, right?
> 
> I do. This is of course best-effort and there's no solution that can work with all the web pages out there. My take is that a good Web author will put any related information (that Lookup cares about) in the same block. If that doesn't work, Lookup will do its best given the partial context. The user can select text manually if that's not enough...

Why don’t we get 3 paragraphs around the word instead?

[Thomas Deniau]

Created attachment 202717 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 202717 [details]
Patch

Clearing flags on attachment: 202717

Committed r150653: <http://trac.webkit.org/changeset/150653>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Tim Horton]

This caused https://bugs.webkit.org/show_bug.cgi?id=117020.