RESOLVED FIXED 115253
[GTK] Catch select.error exceptions in parse_output_lines 
https://bugs.webkit.org/show_bug.cgi?id=115253
Summary [GTK] Catch select.error exceptions in parse_output_lines
Zan Dobersek
Reported 2013-04-26 05:52:16 PDT
[GTK] Catch select.error exceptions in parse_output_lines
Attachments
Patch (1.78 KB, patch)
2013-04-26 05:55 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (1.81 KB, patch)
2013-04-26 05:58 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (1.78 KB, patch)
2013-04-29 00:38 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2013-04-26 05:55:33 PDT
Created attachment 199819 [details] Patch
Zan Dobersek
Comment 2 2013-04-26 05:58:08 PDT
Created attachment 199820 [details] Patch
Zan Dobersek
Comment 3 2013-04-28 14:38:16 PDT
Comment on attachment 199820 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199820&action=review > Tools/gtk/common.py:118 > + print "Ayo" Yeah ... no.
Carlos Garcia Campos
Comment 4 2013-04-29 00:17:11 PDT
What's the error we are currently getting in the bots?
Zan Dobersek
Comment 5 2013-04-29 00:35:20 PDT
Taking the following build as an example: http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/37295/steps/API%20tests/logs/stdio Traceback (most recent call last): File "./Tools/Scripts/run-gtk-tests", line 384, in <module> sys.exit(TestRunner(options, args).run_tests()) File "./Tools/Scripts/run-gtk-tests", line 328, in run_tests g_dbus_connection_real_closed: Remote peer vanished with error: Underlying GIOStream returned 0 bytes on an async read (g-io-error-quark, 0). Exiting. success = self._run_test(test) File "./Tools/Scripts/run-gtk-tests", line 302, in _run_test return self._run_test_glib(test_program) File "./Tools/Scripts/run-gtk-tests", line 290, in _run_test_glib return self._run_test_command(tester_command, self._options.timeout) File "./Tools/Scripts/run-gtk-tests", line 261, in _run_test_command common.parse_output_lines(fd, parse_line) File "./Tools/gtk/common.py", line 117, in parse_output_lines rlist, wlist, xlist = select.select(read_set, [], []) select.error: (4, 'Interrupted system call') The select.error is a simple-enough report about an interrupted system call (errno = EINTR). Might be related to the g_dbus_connection_real_closed error, though I don't know from where the latter could originate.
Zan Dobersek
Comment 6 2013-04-29 00:38:09 PDT
Created attachment 199987 [details] Patch
Zan Dobersek
Comment 7 2013-05-04 00:53:44 PDT
Comment on attachment 199987 [details] Patch Clearing flags on attachment: 199987 Committed r149555: <http://trac.webkit.org/changeset/149555>
Zan Dobersek
Comment 8 2013-05-04 00:53:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.