Bug 115247 - Optimize function and interface object length computation in bindings generator
Summary: Optimize function and interface object length computation in bindings generator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 115250
  Show dependency tree / graph
 
Reported: 2013-04-26 05:21 PDT by Chris Dumez
Modified: 2013-04-26 06:02 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.50 KB, patch)
2013-04-26 05:31 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-04-26 05:21:11 PDT 
We should introduce a new GetFunctionLength() function that efficiently computes the length of a function (i.e. its number of mandatory parameters).

We currently call GenerateFunctionParametersCheck() for that purpose but this is very inefficient because it does a lot more processing than we need in this case, in order to generate the expression to check the parameters.
Comment 1 Chris Dumez 2013-04-26 05:31:22 PDT 
Created attachment 199816 [details]
Patch
Comment 2 Kentaro Hara 2013-04-26 05:34:54 PDT 
Comment on attachment 199816 [details]
Patch

Thanks for cleaning up the mess we introduced!
Comment 3 WebKit Commit Bot 2013-04-26 06:02:18 PDT 
Comment on attachment 199816 [details]
Patch

Clearing flags on attachment: 199816

Committed r149177: <http://trac.webkit.org/changeset/149177>
Comment 4 WebKit Commit Bot 2013-04-26 06:02:22 PDT 
All reviewed patches have been landed.  Closing bug.