Bug 11524 - REGRESSION(r9842): Array.prototype.join should use ToString operator rather than calling toString on each element
Summary: REGRESSION(r9842): Array.prototype.join should use ToString operator rather t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 420+
Hardware: Macintosh OS X 10.4
: P1 Major
Assignee: Nobody
URL:
Keywords: Regression
Depends on:
Blocks:
 
Reported: 2006-11-05 21:19 PST by Mark Rowe (bdash)
Modified: 2006-11-06 00:39 PST (History)
1 user (show)

See Also:


Attachments
Patch (6.29 KB, patch)
2006-11-06 00:05 PST, Mark Rowe (bdash)
mitz: review-
Details | Formatted Diff | Diff
Patch with less stupidity (6.29 KB, patch)
2006-11-06 00:23 PST, Mark Rowe (bdash)
no flags Details | Formatted Diff | Diff
Patch with zero stupidity? (6.29 KB, patch)
2006-11-06 00:28 PST, Mark Rowe (bdash)
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2006-11-05 21:19:04 PST
From Mitz in bug 10720:
> I think this HTMLAnchorElement regression exposed a bug in
> Array.prototype.toString() that was introduced when bug 3991 was fixed (r9842):
> according to the spec (15.4.4.5), unlike toLocaleString(), join() (and thus
> toString()) should not use the array elements' toString(), but rather apply the
> ToString operator to them.
Comment 1 Mark Rowe (bdash) 2006-11-06 00:05:20 PST
Created attachment 11393 [details]
Patch
Comment 2 mitz 2006-11-06 00:21:00 PST
Comment on attachment 11393 [details]
Patch

The code change looks good. There are coding style issues (misplaced stars) and there's a typo in the bug number in the test's name, so r-.
Comment 3 Mark Rowe (bdash) 2006-11-06 00:23:08 PST
Created attachment 11394 [details]
Patch with less stupidity
Comment 4 Mark Rowe (bdash) 2006-11-06 00:28:59 PST
Created attachment 11395 [details]
Patch with zero stupidity?
Comment 5 mitz 2006-11-06 00:31:10 PST
Comment on attachment 11395 [details]
Patch with zero stupidity?

r=me
Comment 6 Mark Rowe (bdash) 2006-11-06 00:39:10 PST
Landed in r17610.