Bug 115237 - [GTK] Set up the TestWebCore in TestWebKitAPI
Summary: [GTK] Set up the TestWebCore in TestWebKitAPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on: 115233 115430 115469 115470
Blocks:
  Show dependency tree / graph
 
Reported: 2013-04-26 01:53 PDT by Zan Dobersek
Modified: 2013-05-04 00:49 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.13 KB, patch)
2013-04-26 02:01 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (5.22 KB, patch)
2013-05-01 12:12 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-04-26 01:53:33 PDT 
[GTK] Set up the TestWebCore in TestWebKitAPI
Comment 1 Zan Dobersek 2013-04-26 02:01:27 PDT 
Created attachment 199803 [details]
Patch
Comment 2 Zan Dobersek 2013-04-26 02:02:41 PDT 
Depends on the cleanup in bug #115233, meaning it won't apply in EWS. Can reupload when that bug is fixed.
Comment 3 Zan Dobersek 2013-04-29 13:16:17 PDT 
Committed r149309: <http://trac.webkit.org/changeset/149309>
Comment 4 WebKit Commit Bot 2013-04-30 11:01:03 PDT 
Re-opened since this is blocked by bug 115430
Comment 5 Zan Dobersek 2013-05-01 12:12:06 PDT 
Created attachment 200232 [details]
Patch
Comment 6 Gustavo Noronha (kov) 2013-05-03 13:12:24 PDT 
Comment on attachment 200232 [details]
Patch

I couldn't spot the change that makes the new version better, I assume it's just that a different change made this change correct?
Comment 7 Zan Dobersek 2013-05-04 00:46:17 PDT 
Yes, that's exactly the case.

Sorry for leaving you confused there, I should have at least mentioned that the underlying issues were fixed in separate bugs or just recommit the patch.
Comment 8 Zan Dobersek 2013-05-04 00:49:24 PDT 
Comment on attachment 200232 [details]
Patch

Clearing flags on attachment: 200232

Committed r149554: <http://trac.webkit.org/changeset/149554>
Comment 9 Zan Dobersek 2013-05-04 00:49:31 PDT 
All reviewed patches have been landed.  Closing bug.