Bug 115232 - Pattern: add missing definitions for the BlackBerry port
Summary: Pattern: add missing definitions for the BlackBerry port
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 114886
Blocks: 111729
  Show dependency treegraph
 
Reported: 2013-04-26 01:07 PDT by Alberto Garcia
Modified: 2014-01-09 23:46 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.79 KB, patch)
2013-04-26 01:13 PDT, Alberto Garcia
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2013-04-26 01:07:45 PDT
The following changes are needed:

- Definition of PlatformPatternPtr
- Declaration of Pattern::platformPattern(), defined in PatternBlackBerry.cpp
- Don't compile the default implementations of platformDestroy() and
  setPlatformPatternSpaceTransform(), since they are already defined
  for BlackBerry.
- Initialize m_pattern to 0.
Comment 1 Alberto Garcia 2013-04-26 01:13:08 PDT
Created attachment 199796 [details]
Patch
Comment 2 Alberto Garcia 2013-04-26 01:16:51 PDT
These changes would conflict with those written for bug 114886, so I
made this patch to be applied on top of that one.

Hence I'm setting a dependency on bug 114886. After that one is fixed
we can apply this one.
Comment 3 Alberto Garcia 2013-05-02 07:15:32 PDT
Comment on attachment 199796 [details]
Patch

Removing this patch by now, I might need to change it.
Comment 4 Alberto Garcia 2014-01-09 23:46:57 PST
This bug is obsolete, closing.