Bug 115223 – [WebKit2] Loading a resource from a custom protocol in a synchronous XHR times out

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Andy Estes]

[WebKit2] Loading a resource from a custom protocol in a synchronous XHR times out

[Andy Estes]

<rdar://problem/12890540>

[Andy Estes]

Created attachment 199785 [details]
Patch

[Andy Estes]

Committed r149194: <http://trac.webkit.org/changeset/149194>

[Alexey Proskuryakov]

This change means that messages are now handled on a secondary thread. What is the design for CustomProtocolManager thread safety?

[Andy Estes]

(In reply to comment #4)
> This change means that messages are now handled on a secondary thread. What is the design for CustomProtocolManager thread safety?

The messages that are handled on this thread do two things:

1) Look up a WKCustomProtocol by ID. This was made thread-safe in <http://trac.webkit.org/changeset/149121>.
2) Call a method on NSURLProtocolClient. I believe this is thread-safe by code inspection.

[Andy Estes]

(In reply to comment #4)
> This change means that messages are now handled on a secondary thread. What is the design for CustomProtocolManager thread safety?

Oh, we do need to protect m_registeredSchemes. We add/remove schemes to that set from the work queue but look them up from some thread managed by NSURLConnection. I'll fix that in a follow-up. Thanks for making me double-check!

[Andy Estes]

(In reply to comment #6)
> I'll fix that in a follow-up.

Filed <https://bugs.webkit.org/show_bug.cgi?id=115267>.