Bug 115219 - StaticHashSetNodeList is unnecessary
Summary: StaticHashSetNodeList is unnecessary
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-25 21:10 PDT by Ryosuke Niwa
Modified: 2013-04-28 15:20 PDT (History)
14 users (show)

See Also:

Attachments
Cleanup (32.34 KB, patch)
2013-04-25 21:13 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Fixed EFL and Qt builds (32.80 KB, patch)
2013-04-25 21:23 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Fixed Mac build (35.70 KB, patch)
2013-04-25 21:42 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Fixed more builds (36.18 KB, patch)
2013-04-26 02:36 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Fixed Windows build (36.63 KB, patch)
2013-04-26 03:10 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Patch for landing (39.23 KB, patch)
2013-04-27 12:37 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Another fixed Windows build (40.70 KB, patch)
2013-04-27 13:44 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Another GTK+ fix (41.60 KB, patch)
2013-04-27 14:14 PDT, Ryosuke Niwa 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-04-25 21:10:04 PDT 
StaticHashSetNodeList is only used for Internals methods and as an intermediate data structure in TouchAdjustments.cpp.
We should get rid of this class.
Comment 2 Ryosuke Niwa 2013-04-25 21:13:42 PDT 
Created attachment 199776 [details]
Cleanup
Comment 3 EFL EWS Bot 2013-04-25 21:19:52 PDT 
Comment on attachment 199776 [details]
Cleanup

Attachment 199776 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/223055
Comment 4 EFL EWS Bot 2013-04-25 21:20:56 PDT 
Comment on attachment 199776 [details]
Cleanup

Attachment 199776 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/165357
Comment 5 Early Warning System Bot 2013-04-25 21:21:20 PDT 
Comment on attachment 199776 [details]
Cleanup

Attachment 199776 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/200538
Comment 6 Ryosuke Niwa 2013-04-25 21:23:48 PDT 
Created attachment 199777 [details]
Fixed EFL and Qt builds
Comment 7 Ryosuke Niwa 2013-04-25 21:42:21 PDT 
Created attachment 199779 [details]
Fixed Mac build
Comment 8 Early Warning System Bot 2013-04-25 21:51:37 PDT 
Comment on attachment 199779 [details]
Fixed Mac build

Attachment 199779 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/59993
Comment 9 Early Warning System Bot 2013-04-25 21:52:04 PDT 
Comment on attachment 199779 [details]
Fixed Mac build

Attachment 199779 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/126286
Comment 10 Build Bot 2013-04-25 22:20:20 PDT 
Comment on attachment 199779 [details]
Fixed Mac build

Attachment 199779 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/209054
Comment 11 kov's GTK+ EWS bot 2013-04-25 22:43:35 PDT 
Comment on attachment 199779 [details]
Fixed Mac build

Attachment 199779 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/229013
Comment 12 Ryosuke Niwa 2013-04-26 02:36:46 PDT 
Created attachment 199807 [details]
Fixed more builds
Comment 13 Build Bot 2013-04-26 03:00:25 PDT 
Comment on attachment 199807 [details]
Fixed more builds

Attachment 199807 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/77516
Comment 14 Ryosuke Niwa 2013-04-26 03:10:01 PDT 
Created attachment 199809 [details]
Fixed Windows build
Comment 15 Build Bot 2013-04-26 03:47:31 PDT 
Comment on attachment 199809 [details]
Fixed Windows build

Attachment 199809 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/61539
Comment 16 kov's GTK+ EWS bot 2013-04-26 05:48:17 PDT 
Comment on attachment 199809 [details]
Fixed Windows build

Attachment 199809 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/171432
Comment 17 Ryosuke Niwa 2013-04-27 12:37:30 PDT 
Created attachment 199907 [details]
Patch for landing
Comment 18 Build Bot 2013-04-27 13:06:09 PDT 
Comment on attachment 199907 [details]
Patch for landing

Attachment 199907 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/229023
Comment 19 Ryosuke Niwa 2013-04-27 13:44:47 PDT 
Created attachment 199913 [details]
Another fixed Windows build
Comment 20 Ryosuke Niwa 2013-04-27 13:45:10 PDT 
Comment on attachment 199913 [details]
Another fixed Windows build

Waiting for EWS to process it.
Comment 21 kov's GTK+ EWS bot 2013-04-27 14:07:58 PDT 
Comment on attachment 199913 [details]
Another fixed Windows build

Attachment 199913 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/240094
Comment 22 Ryosuke Niwa 2013-04-27 14:14:49 PDT 
Created attachment 199917 [details]
Another GTK+ fix
Comment 23 Build Bot 2013-04-27 21:48:57 PDT 
Comment on attachment 199917 [details]
Another GTK+ fix

Attachment 199917 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/25493
Comment 24 Ryosuke Niwa 2013-04-28 15:20:51 PDT 
Committed r149262: <http://trac.webkit.org/changeset/149262>