RESOLVED FIXED 115218
Remove support for Chromium from build/update script 
https://bugs.webkit.org/show_bug.cgi?id=115218
Summary Remove support for Chromium from build/update script
Seokju Kwon
Reported 2013-04-25 20:19:12 PDT
SSIA
Attachments
Patch (5.41 KB, patch)
2013-04-25 20:21 PDT, Seokju Kwon 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Seokju Kwon
Comment 1 2013-04-25 20:21:39 PDT
Created attachment 199775 [details] Patch
Gyuyoung Kim
Comment 2 2013-04-25 21:00:59 PDT
Comment on attachment 199775 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199775&action=review > Tools/Scripts/update-webkit:58 > 'gyp' => \$useGYP, Don't you need to remove 'gyp' as well ? As far as I know, gyp was for chromium
Seokju Kwon
Comment 3 2013-04-25 21:06:37 PDT
It seems that isAppleMacWebKit is using it. elsif (isAppleMacWebKit()) { my @local_options = @options; push @local_options, XcodeCoverageSupportOptions() if $coverageSupport && $project ne "ANGLE"; my $useGYPProject = $useGYP && ($project =~ "WebCore|JavaScriptCore"); my $projectPath = $useGYPProject ? "gyp/$project" : $project; $projectPath = $project =~ /gtest/ ? "xcode/gtest" : $project; $result = buildXCodeProject($projectPath, $clean, @local_options, @ARGV); }
WebKit Commit Bot
Comment 4 2013-04-25 21:49:25 PDT
Comment on attachment 199775 [details] Patch Clearing flags on attachment: 199775 Committed r149166: <http://trac.webkit.org/changeset/149166>
WebKit Commit Bot
Comment 5 2013-04-25 21:49:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.