Bug 115218 - Remove support for Chromium from build/update script
Summary: Remove support for Chromium from build/update script
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-25 20:19 PDT by Seokju Kwon
Modified: 2013-04-25 21:49 PDT (History)
1 user (show)

See Also:

Attachments
Patch (5.41 KB, patch)
2013-04-25 20:21 PDT, Seokju Kwon 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Seokju Kwon 2013-04-25 20:19:12 PDT 
SSIA
Comment 1 Seokju Kwon 2013-04-25 20:21:39 PDT 
Created attachment 199775 [details]
Patch
Comment 2 Gyuyoung Kim 2013-04-25 21:00:59 PDT 
Comment on attachment 199775 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199775&action=review

> Tools/Scripts/update-webkit:58
>      'gyp' => \$useGYP,

Don't you need to remove 'gyp' as well ? As far as I know, gyp was for chromium
Comment 3 Seokju Kwon 2013-04-25 21:06:37 PDT 
It seems that isAppleMacWebKit is using it.

elsif (isAppleMacWebKit()) {
        my @local_options = @options;
        push @local_options, XcodeCoverageSupportOptions() if $coverageSupport && $project ne "ANGLE";
        my $useGYPProject = $useGYP && ($project =~ "WebCore|JavaScriptCore");
        my $projectPath = $useGYPProject ? "gyp/$project" : $project;
        $projectPath = $project =~ /gtest/ ? "xcode/gtest" : $project;
        $result = buildXCodeProject($projectPath, $clean, @local_options, @ARGV);
    }
Comment 4 WebKit Commit Bot 2013-04-25 21:49:25 PDT 
Comment on attachment 199775 [details]
Patch

Clearing flags on attachment: 199775

Committed r149166: <http://trac.webkit.org/changeset/149166>
Comment 5 WebKit Commit Bot 2013-04-25 21:49:27 PDT 
All reviewed patches have been landed.  Closing bug.