Bug 115198 - [WIN] Add WTF_USE_IMLANG_FONT_LINK2
Summary: [WIN] Add WTF_USE_IMLANG_FONT_LINK2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-25 12:43 PDT by Patrick R. Gansterer
Modified: 2013-04-29 09:32 PDT (History)
3 users (show)

See Also:


Attachments
Patch (7.53 KB, patch)
2013-04-25 12:46 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff
Patch (8.72 KB, patch)
2013-04-29 07:21 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2013-04-25 12:43:04 PDT
[WIN] Add WTF_USE_IMLANG_FONT_LINK2
Comment 1 Patrick R. Gansterer 2013-04-25 12:46:31 PDT
Created attachment 199741 [details]
Patch
Comment 2 Andreas Kling 2013-04-29 06:57:29 PDT
Comment on attachment 199741 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199741&action=review

> Source/WebCore/platform/graphics/FontCache.h:60
> +#if !defined(WTF_USE_IMLANG_FONT_LINK2) && !OS(WINCE)
> +#define WTF_USE_IMLANG_FONT_LINK2 1
> +#endif

Should we really be defining USE()-flags outside of Platform.h?
Comment 3 Patrick R. Gansterer 2013-04-29 07:21:48 PDT
Created attachment 200006 [details]
Patch
Comment 4 Andreas Kling 2013-04-29 07:31:06 PDT
Comment on attachment 200006 [details]
Patch

rs=me
Comment 5 WebKit Commit Bot 2013-04-29 09:32:05 PDT
Comment on attachment 200006 [details]
Patch

Clearing flags on attachment: 200006

Committed r149293: <http://trac.webkit.org/changeset/149293>
Comment 6 WebKit Commit Bot 2013-04-29 09:32:06 PDT
All reviewed patches have been landed.  Closing bug.