Bug 115193 - Glyphs may fail to render when using SVG font
Summary: Glyphs may fail to render when using SVG font
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-04-25 12:12 PDT by Antoine Quint
Modified: 2013-04-25 14:28 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.70 KB, patch)
2013-04-25 12:24 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2013-04-25 12:12:05 PDT
In certain circumstances, glyphs fail to render when using SVG fonts as the GlyphBuffer gets incorrect data when running through SimpleFontData::applyTransforms(). This method ought not be ran for SVG fonts.
Comment 1 Antoine Quint 2013-04-25 12:12:29 PDT
<rdar://problem/12893178>
Comment 2 Antoine Quint 2013-04-25 12:24:51 PDT
Created attachment 199736 [details]
Patch
Comment 3 Simon Fraser (smfr) 2013-04-25 12:49:53 PDT
Comment on attachment 199736 [details]
Patch

There should be a way to make a layout test for this, no?
Comment 4 Antoine Quint 2013-04-25 12:51:31 PDT
(In reply to comment #3)
> (From update of attachment 199736 [details])
> There should be a way to make a layout test for this, no?

I couldn't manage to make a test case that'd reproduce the issue with a free SVG font.
Comment 5 Tim Horton 2013-04-25 12:54:00 PDT
(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 199736 [details] [details])
> > There should be a way to make a layout test for this, no?
> 
> I couldn't manage to make a test case that'd reproduce the issue with a free SVG font.

Can't you just make one that causes trouble? They're not too hard to make (and we have some small examples in the SVG layout tests).
Comment 6 WebKit Commit Bot 2013-04-25 14:28:43 PDT
Comment on attachment 199736 [details]
Patch

Clearing flags on attachment: 199736

Committed r149144: <http://trac.webkit.org/changeset/149144>
Comment 7 WebKit Commit Bot 2013-04-25 14:28:45 PDT
All reviewed patches have been landed.  Closing bug.