Bug 11519 – REGRESSION: Disabled file upload control doesn't have disabled appearance, failing fast/forms/file-input-disabled.html

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

Mac-themed file upload controls that are disabled should have the disabled appearance and not highlight on mousedown. See fast/forms/file-input-disabled.html.

[Rob Buis]

Created attachment 11568 [details]
First attempt

The patch does a little more than fixing the problem. I expect the 3 other state values to cause problems too, that is why I include them in this patch. I'd like to discuss whether this is the right approach, whether we need more testcases for the other 3 state values or whether existing testcases cover it.
Cheers,

Rob.

[Maciej Stachowiak]

Comment on attachment 11568 [details]
First attempt

The ChangeLog has a conflict marker left in it:

+>>>>>>> .r17847

I'm not sure the changes besides disabled are well enough covered by tests.

[Rob Buis]

Created attachment 11588 [details]
Improved patch

With hindsight, dealing with checked property for file input makes no sense at all. The file input also does not seem to react to setting active/select(). Finally it is not needed to set the focus property, I tested it and it seems to work on ToT. So really I think I was trying to do too much and just dealing with disabled is all that is needed.
Cheers,

Rob.

[Maciej Stachowiak]

Comment on attachment 11588 [details]
Improved patch

r=me

[Mark Rowe (bdash)]

Landed by Rob in 17867.

The patch left the button text black (not grayed out as it should be). Filed bug 11874 on that.