Bug 11519 - REGRESSION: Disabled file upload control doesn't have disabled appearance, failing fast/forms/file-input-disabled.html
Summary: REGRESSION: Disabled file upload control doesn't have disabled appearance, fa...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Nobody
Keywords: LayoutTestFailure, Regression
Depends on:
Reported: 2006-11-04 12:58 PST by mitz
Modified: 2006-12-19 06:31 PST (History)
2 users (show)

See Also:

First attempt (2.41 KB, patch)
2006-11-18 14:51 PST, Rob Buis
no flags Details | Formatted Diff | Diff
Improved patch (2.01 KB, patch)
2006-11-20 12:51 PST, Rob Buis
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2006-11-04 12:58:33 PST
Mac-themed file upload controls that are disabled should have the disabled appearance and not highlight on mousedown. See fast/forms/file-input-disabled.html.
Comment 1 Rob Buis 2006-11-18 14:51:21 PST
Created attachment 11568 [details]
First attempt

The patch does a little more than fixing the problem. I expect the 3 other state values to cause problems too, that is why I include them in this patch. I'd like to discuss whether this is the right approach, whether we need more testcases for the other 3 state values or whether existing testcases cover it.

Comment 2 Maciej Stachowiak 2006-11-19 21:54:54 PST
Comment on attachment 11568 [details]
First attempt

The ChangeLog has a conflict marker left in it:

+>>>>>>> .r17847

I'm not sure the changes besides disabled are well enough covered by tests.
Comment 3 Rob Buis 2006-11-20 12:51:45 PST
Created attachment 11588 [details]
Improved patch

With hindsight, dealing with checked property for file input makes no sense at all. The file input also does not seem to react to setting active/select(). Finally it is not needed to set the focus property, I tested it and it seems to work on ToT. So really I think I was trying to do too much and just dealing with disabled is all that is needed.

Comment 4 Maciej Stachowiak 2006-11-21 01:07:05 PST
Comment on attachment 11588 [details]
Improved patch

Comment 5 Mark Rowe (bdash) 2006-11-21 04:09:50 PST
Landed by Rob in 17867.
Comment 6 mitz 2006-12-19 06:31:03 PST
The patch left the button text black (not grayed out as it should be). Filed bug 11874 on that.