Bug 115189 – [BlackBerry] Enable balanced page group load deferrer behaviour.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Mike Lattanzio]

Every port uses PageGroupLoadDeferrer wrapper objects, as do we. 
We should therefore enable the balanced page group load deferrer behavior so they can be safely nested.

[Mike Lattanzio]

Created attachment 199695 [details]
Patch

[Rob Buis]

Comment on attachment 199695 [details]
Patch

Ok.

[WebKit Commit Bot]

Comment on attachment 199695 [details]
Patch

Rejecting attachment 199695 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 199695, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
Rob Buis']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file Source/WebKit/blackberry/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/blackberry/Api/WebPage.cpp
Hunk #1 FAILED at 631.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/Api/WebPage.cpp.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Rob Buis']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/11340

[Joe Mason]

    I've done an audit to prove that this use is safe. Unlike other ports we don't expose the setWantsBalancedSetDefersLoadingBehavior in the platform API, and we don't expose any access to setDefersLoading except for a wrapper for PageGroupLoadDeferrer, which is meant to be created on the stack and calls setDefersLoading in the constructor and destructor, keeping the calls balanced. So we definitely do not have any unbalanced calls to setDefersLoading.

    And since we assumed PageGroupLoadDeferrers could be nested, and make heavy use of them, it's unsafe to NOT set wantsBalancedSetDefersLoadingBehavior.

[Joe Mason]

(In reply to comment #3)
> (From update of attachment 199695 [details])
> patching file Source/WebKit/blackberry/Api/WebPage.cpp
> Hunk #1 FAILED at 631.
> 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/Api/WebPage.cpp.rej

Oops, this was based on the internal branch and not the upstream branch and I guess it's diverged. We'll need to make the change in the internal and svn/master branches simultaneously, and merge them at the next rebase. (Hopefully the rest of the local changes will be upstreamed by then.)

Leaving this open until there's time to do that.

[Mike Lattanzio]

Created attachment 199727 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 199727 [details]
Patch

Clearing flags on attachment: 199727

Committed r149135: <http://trac.webkit.org/changeset/149135>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.