Bug 115179 - Add support for Web IDL callback interfaces to the bindings generator
Summary: Add support for Web IDL callback interfaces to the bindings generator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: http://dev.w3.org/2006/webapi/WebIDL/...
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-25 08:15 PDT by Chris Dumez
Modified: 2013-04-25 11:55 PDT (History)
12 users (show)

See Also:

Attachments
Patch (18.99 KB, patch)
2013-04-25 08:23 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-04-25 08:15:22 PDT 
Our bindings generator currently supports a Webkit-specific [Callback] extended attribute on interfaces instead of the standard Web IDL callback interfaces [1].

I believe it is a good idea to follow standard Web IDL for cases where a solution exists.

[1] http://dev.w3.org/2006/webapi/WebIDL/#dfn-callback-interface
Comment 1 Chris Dumez 2013-04-25 08:23:27 PDT 
Created attachment 199662 [details]
Patch
Comment 2 Kentaro Hara 2013-04-25 08:26:53 PDT 
Comment on attachment 199662 [details]
Patch

Thank you very much for keeping the IDL parser consistent between JSC and V8, and with the spec.
Comment 3 WebKit Commit Bot 2013-04-25 08:54:09 PDT 
Comment on attachment 199662 [details]
Patch

Clearing flags on attachment: 199662

Committed r149113: <http://trac.webkit.org/changeset/149113>
Comment 4 WebKit Commit Bot 2013-04-25 08:54:12 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Chris Dumez 2013-04-25 11:55:23 PDT 
I updated the WebKitIDL wiki accordingly:
https://trac.webkit.org/wiki/WebKitIDL?action=diff&version=86&old_version=85