Bug 115178 – [BlackBerry] Make scroll position adjustment work with pages with fixed position elements

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Iris Wu]

Currently the position smart scroll adjusts is the top left point of the viewport. On the page with fixed position elements, we want it to adjust the position beneath the fixed elements so it can be always visible.

[Iris Wu]

Created attachment 199664 [details]
Patch with ChangeLog

[Rob Buis]

Comment on attachment 199664 [details]
Patch with ChangeLog

View in context: https://bugs.webkit.org/attachment.cgi?id=199664&action=review

> Source/WebKit/blackberry/Api/WebPage.cpp:5255
> +void WebPage::findFixedElementRect(LayerCompositingThread* layer, Platform::IntRect& fixedElementRect)

It seems like this method should be on LayerCompositingThread, since every operation uses layer.

[Arvid Nilsson]

(In reply to comment #2)
> (From update of attachment 199664 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=199664&action=review
> 
> > Source/WebKit/blackberry/Api/WebPage.cpp:5255
> > +void WebPage::findFixedElementRect(LayerCompositingThread* layer, Platform::IntRect& fixedElementRect)
> 
> It seems like this method should be on LayerCompositingThread, since every operation uses layer.

I was thinking of suggesting to put this method on WebPageCompositorPrivate, at least. Maybe moving it to LayerCompositingThread makes even more sense - but I think traversing the layers should be the responsibility of some managing class like LayerRenderer or WebPageCompositor(Private), not LayerCompositingThread itself.

[Iris Wu]

Created attachment 199689 [details]
Patch with ChangeLog

[WebKit Commit Bot]

Attachment 199689 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPage.cpp', u'Source/WebKit/blackberry/Api/WebPage.h', u'Source/WebKit/blackberry/Api/WebPageCompositor.cpp', u'Source/WebKit/blackberry/Api/WebPageCompositor_p.h', u'Source/WebKit/blackberry/ChangeLog']" exit_code: 1
Source/WebKit/blackberry/Api/WebPageCompositor_p.h:107:  The parameter name "layer" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Iris Wu]

Created attachment 199693 [details]
Patch with ChangeLog

[Rob Buis]

Comment on attachment 199693 [details]
Patch with ChangeLog

LGTM.

[WebKit Commit Bot]

Comment on attachment 199693 [details]
Patch with ChangeLog

Clearing flags on attachment: 199693

Committed r149137: <http://trac.webkit.org/changeset/149137>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Iris Wu]

Created attachment 199835 [details]
debug build fix

[Iris Wu]

New patch added

[Rob Buis]

Comment on attachment 199835 [details]
debug build fix

Ok.

[WebKit Commit Bot]

Comment on attachment 199835 [details]
debug build fix

Clearing flags on attachment: 199835

Committed r149487: <http://trac.webkit.org/changeset/149487>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.