Bug 115163 - [GTK] Tools/gtk/install-dependencies is missing the ragel dependency
Summary: [GTK] Tools/gtk/install-dependencies is missing the ragel dependency
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-25 01:49 PDT by Xavi
Modified: 2013-04-25 07:18 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.46 KB, patch)
2013-04-25 02:21 PDT, Xavi
no flags Details | Formatted Diff | Diff
Patch (1.46 KB, patch)
2013-04-25 02:49 PDT, Xavi
no flags Details | Formatted Diff | Diff
Patch (1.46 KB, patch)
2013-04-25 04:26 PDT, Xavi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xavi 2013-04-25 01:49:15 PDT
harfbuzz requires ragel package to be installed.
Comment 1 Xavi 2013-04-25 02:21:55 PDT
Created attachment 199640 [details]
Patch
Comment 2 Xan Lopez 2013-04-25 02:36:33 PDT
Comment on attachment 199640 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199640&action=review

Maybe correct the name in the ChangeLog? A good way to learn about annoying reviewers ;)

> Tools/ChangeLog:9
> +        which is expected when building hardbuff

Not very important, but the name is "harfbuzz".
Comment 3 Adrian Perez 2013-04-25 02:45:17 PDT
Informally reviewing... There is another small typo in the ChangeLog,
please change “scrtip” to “script”. It would be nice to fix it when
you edit the ChangeLog with Xan's comment. Apart from that, looks fine.
Comment 4 Xavi 2013-04-25 02:49:09 PDT
Created attachment 199644 [details]
Patch
Comment 5 Xan Lopez 2013-04-25 03:06:51 PDT
Comment on attachment 199644 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199644&action=review

> Tools/ChangeLog:9
> +        which is expected when building HarfBuff.

Still wrong :D! See http://www.freedesktop.org/wiki/Software/HarfBuzz
Comment 6 Xavi 2013-04-25 04:26:16 PDT
Created attachment 199650 [details]
Patch
Comment 7 WebKit Commit Bot 2013-04-25 07:18:34 PDT
Comment on attachment 199650 [details]
Patch

Clearing flags on attachment: 199650

Committed r149109: <http://trac.webkit.org/changeset/149109>
Comment 8 WebKit Commit Bot 2013-04-25 07:18:36 PDT
All reviewed patches have been landed.  Closing bug.