Bug 115155 - Delete maketokenizer
Summary: Delete maketokenizer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: BlinkMergeCandidate
: 123801 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-04-25 00:52 PDT by Ryosuke Niwa
Modified: 2013-11-05 08:04 PST (History)
11 users (show)

See Also:

Attachments
Patch (5.71 KB, patch)
2013-11-05 06:45 PST, Éva Balázsfalvi 		no flags Details | Formatted Diff | Diff
Patch (5.90 KB, patch)
2013-11-05 07:31 PST, Éva Balázsfalvi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-04-25 00:52:12 PDT 
https://chromium.googlesource.com/chromium/blink/+/2a1c8aaf867f707ccdcd8893446e907e2aa2e1c2

This script was used to generate the old flex based CSS tokenizer. It
was replaced by a custom tokenizer in r106217 but the script wasn't
removed. Since there is no mention of it in the original bug nor any
reference to maketokenizer in our build files, it's probably an
oversight.
Comment 1 Csaba Osztrogonác 2013-11-05 06:30:06 PST 
*** Bug 123801 has been marked as a duplicate of this bug. ***
Comment 2 Éva Balázsfalvi 2013-11-05 06:45:48 PST 
Created attachment 216033 [details]
Patch
Comment 3 Éva Balázsfalvi 2013-11-05 07:31:38 PST 
Created attachment 216037 [details]
Patch
Comment 4 Zoltan Herczeg 2013-11-05 07:40:46 PST 
Comment on attachment 216037 [details]
Patch

Nice!

rs=me
Comment 5 WebKit Commit Bot 2013-11-05 08:04:24 PST 
Comment on attachment 216037 [details]
Patch

Clearing flags on attachment: 216037

Committed r158673: <http://trac.webkit.org/changeset/158673>
Comment 6 WebKit Commit Bot 2013-11-05 08:04:27 PST 
All reviewed patches have been landed.  Closing bug.