Bug 115152 – [EFL][WK2] Add APIs to set/get the text zoom factor.

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebKit EFL

[Jaehun Lim]

Add ewk APIs for the text zoom factor.

[Jaehun Lim]

Created attachment 199627 [details]
Patch

[Chris Dumez]

Comment on attachment 199627 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199627&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:860
> + * @param new text zoom factor

Missing @param name

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:864
> +EAPI Eina_Bool ewk_view_text_zoom_factor_set(Evas_Object* ewkView, double zoomFactor);

Star on wrong side. First parameter should be called "o"

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:873
> +EAPI double ewk_view_text_zoom_factor_get(const Evas_Object* ewkView);

Ditto.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:1006
> +}

Would be nice to try a few error cases as well. What if I call ewk_view_text_zoom_factor_set(webView(), -1) ?

[Chris Dumez]

Related to zooming so Kenneth may want to take a look.

[Gyuyoung Kim]

Comment on attachment 199627 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199627&action=review

Set r-

>> Source/WebKit2/UIProcess/API/efl/ewk_view.h:864
>> +EAPI Eina_Bool ewk_view_text_zoom_factor_set(Evas_Object* ewkView, double zoomFactor);
> 
> Star on wrong side. First parameter should be called "o"

And also, s/zoomFactor/zoom_factor/g

[Ryuan Choi]

I am not sure whether kenneth is still interested in ewebkit2.

Anyway, it's bit old without any comments but it is still used in ewebkit on the tizen.

[Michael Catanzaro]

Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.