Bug 115150 – HTMLOptionsCollection's namedItem and name getter should return the first item

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Ryosuke Niwa]

In http://trac.webkit.org/changeset/135093, I've made only HTMLOptionsCollection and HTMLFormControlsCollection's namedItem and name getter return node lists when there are multiple items of the same name.

However, the specification has since been updated so that HTMLOptionsCollection::namedItem and its named getter only returns the first item when there are multiple items of the same name.
http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#htmloptionscollection

Fix this so that we can speed-up namedItem and name getter of HTMLOptionsCollection.

[Ryosuke Niwa]

Created attachment 199623 [details]
Fixes the bug

[Build Bot]

Comment on attachment 199623 [details]
Fixes the bug

Attachment 199623 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/139504

New failing tests:
fast/dom/HTMLSelectElement/named-options.html
fast/dom/html-collections-named-getter.html

[Build Bot]

Created attachment 199626 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.2

[Ryosuke Niwa]

Created attachment 199632 [details]
Fixed baselines

[Andreas Kling]

Comment on attachment 199632 [details]
Fixed baselines

Very nice!
r=me

[WebKit Commit Bot]

Comment on attachment 199632 [details]
Fixed baselines

Clearing flags on attachment: 199632

Committed r149126: <http://trac.webkit.org/changeset/149126>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.