Bug 115143 - Add support for Math.imul
: Add support for Math.imul
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: New Bugs
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Oliver Hunt
: InRadar
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-24 18:00 PDT by Oliver Hunt
Modified: 2013-04-25 17:47 PDT (History)
4 users (show)

See Also:


Attachments
Patch (29.88 KB, patch)
2013-04-24 18:03 PDT, Oliver Hunt
no flags Details | Formatted Diff | Diff
Patch (27.94 KB, patch)
2013-04-24 19:25 PDT, Oliver Hunt
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (505.74 KB, application/zip)
2013-04-24 21:19 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (485.16 KB, application/zip)
2013-04-25 01:57 PDT, Build Bot
no flags Details
Patch (29.94 KB, patch)
2013-04-25 17:29 PDT, Oliver Hunt
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2013-04-24 18:00:22 PDT
Add support for Math.imul
Comment 1 Oliver Hunt 2013-04-24 18:03:02 PDT
Created attachment 199571 [details]
Patch
Comment 2 Filip Pizlo 2013-04-24 18:05:30 PDT
Comment on attachment 199571 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199571&action=review

I think FixupPhase is borked - it should call the fixIntEdge() thingy.

> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:215
> +            setUseKindAndUnboxIfProfitable<Int32Use>(node->child1());
> +            setUseKindAndUnboxIfProfitable<Int32Use>(node->child2());

Why doesn't this call fixIntEdge() instead, like the bit ops do?
Comment 3 Oliver Hunt 2013-04-24 19:25:56 PDT
Created attachment 199608 [details]
Patch
Comment 4 WebKit Commit Bot 2013-04-24 19:27:27 PDT
Attachment 199608 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/js/Object-getOwnPropertyNames-expected.txt', u'LayoutTests/fast/js/imul.html', u'LayoutTests/fast/js/regress/imul-double-only-expected.txt', u'LayoutTests/fast/js/regress/imul-double-only.html', u'LayoutTests/fast/js/regress/imul-int-only-expected.txt', u'LayoutTests/fast/js/regress/imul-int-only.html', u'LayoutTests/fast/js/regress/imul-mixed-expected.txt', u'LayoutTests/fast/js/regress/imul-mixed.html', u'LayoutTests/fast/js/regress/script-tests/imul-double-only.js', u'LayoutTests/fast/js/regress/script-tests/imul-int-only.js', u'LayoutTests/fast/js/regress/script-tests/imul-mixed.js', u'LayoutTests/fast/js/script-tests/Object-getOwnPropertyNames.js', u'LayoutTests/fast/js/script-tests/imul.js', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/create_hash_table', u'Source/JavaScriptCore/dfg/DFGAbstractState.cpp', u'Source/JavaScriptCore/dfg/DFGBackwardsPropagationPhase.cpp', u'Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp', u'Source/JavaScriptCore/dfg/DFGCSEPhase.cpp', u'Source/JavaScriptCore/dfg/DFGFixupPhase.cpp', u'Source/JavaScriptCore/dfg/DFGNodeType.h', u'Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp', u'Source/JavaScriptCore/jit/ThunkGenerators.cpp', u'Source/JavaScriptCore/jit/ThunkGenerators.h', u'Source/JavaScriptCore/runtime/Intrinsic.h', u'Source/JavaScriptCore/runtime/MathObject.cpp', u'Source/JavaScriptCore/runtime/VM.cpp']" exit_code: 1
LayoutTests/ChangeLog:12:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 1 in 32 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Build Bot 2013-04-24 21:19:50 PDT
Comment on attachment 199608 [details]
Patch

Attachment 199608 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/26810

New failing tests:
fast/js/regress/imul-mixed.html
fast/js/imul.html
Comment 6 Build Bot 2013-04-24 21:19:51 PDT
Created attachment 199618 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2
Comment 7 Build Bot 2013-04-25 01:57:17 PDT
Comment on attachment 199608 [details]
Patch

Attachment 199608 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/191170

New failing tests:
fast/js/regress/imul-mixed.html
fast/js/imul.html
Comment 8 Build Bot 2013-04-25 01:57:19 PDT
Created attachment 199635 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.2
Comment 9 Oliver Hunt 2013-04-25 17:29:53 PDT
Created attachment 199768 [details]
Patch
Comment 10 Oliver Hunt 2013-04-25 17:40:32 PDT
Committed r149159: <http://trac.webkit.org/changeset/149159>
Comment 11 Oliver Hunt 2013-04-25 17:47:10 PDT
<rdar://problem/13744222>