Bug 115142 – Permit ~/Library to be a symlink

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Simon Cooper]

Permit ~/Library to be a symlink

[Simon Cooper]

Created attachment 199570 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 199570 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199570&action=review

Looks good to me, with a question about pwd.pw_dir encoding below.

Note however that this behavior doesn't quite match AppSandbox, which also allows ~/Library/Preferences to be a symlink.

> Source/WebKit2/Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:18
> +(define (home-library-regex home-library-relative-regex)
> +  (regex (string-append "^" (regex-quote (param "HOME_LIBRARY_DIR")) home-library-relative-regex)))

Indentation should be 4 characters here, too.

> Source/WebKit2/Shared/mac/ChildProcessMac.mm:142
> +    String libraryPath = String(pwd.pw_dir);

This constructor treats the input as Latin-1. Is this correct, or should it be UTF-8? In the latter case, String::fromUTF8() is the right way to create the String object.

[Simon Cooper]

Created attachment 199861 [details]
Patch

[Simon Cooper]

Updated the patch to support both ~/Library and ~/Library/Preferences.

Made sure that a home directory containing unicode makes it to the Sandboxing without being mangled.

[Alexey Proskuryakov]

Comment on attachment 199861 [details]
Patch

Commit queue won't land this patch because of spaces. I'll land manually.

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/r149217>.