Implementors of CachedResource subclasses should be forced to decide if encoded data can be replaced Came out of discussion in https://bugs.webkit.org/show_bug.cgi?id=115131
Created attachment 199534 [details] Patch v1
Comment on attachment 199534 [details] Patch v1 Attachment 199534 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/178193
Comment on attachment 199534 [details] Patch v1 Attachment 199534 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/96958
Oh boy, somebody creates CachedResources directly... that's bogus. *sigh*
Comment on attachment 199534 [details] Patch v1 Attachment 199534 [details] did not pass gtk-wk2-ews (gtk-wk2): Output: http://webkit-queues.appspot.com/results/206125
Created attachment 199535 [details] Patch v2
Comment on attachment 199535 [details] Patch v2 This patch looks good, but I am not sure about the name mayTryReplaceEncodedData(). "try replace" just sounds awkward. mayTryToReplaceEncodedData()?
(In reply to comment #7) > (From update of attachment 199535 [details]) > This patch looks good, but I am not sure about the name mayTryReplaceEncodedData(). "try replace" just sounds awkward. mayTryToReplaceEncodedData()? The wording is symmetrical with the call that this method enables, which is "tryReplaceEncodedData()" If I recall, there was a small bit of debate on that naming a month ago, but it's what we stuck with. =/ Thanks for the review!
http://trac.webkit.org/changeset/149079