Bug 115129 - DFG doesn't support to_jsnumber
Summary: DFG doesn't support to_jsnumber
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-24 14:43 PDT by Oliver Hunt
Modified: 2013-04-25 18:17 PDT (History)
9 users (show)

See Also:


Attachments
patch (3.73 KB, patch)
2013-04-24 14:43 PDT, Oliver Hunt
no flags Details | Formatted Diff | Diff
the patch (6.86 KB, patch)
2013-04-25 16:29 PDT, Filip Pizlo
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2013-04-24 14:43:23 PDT
Currently triggering assertions, not sure if they're just wrong, or if i have other issues
Comment 1 Oliver Hunt 2013-04-24 14:43:56 PDT
Created attachment 199519 [details]
patch

May be wrong in ways other than just the incorrect assertion
Comment 2 Filip Pizlo 2013-04-25 16:17:58 PDT
I'm looking at this now.
Comment 3 Filip Pizlo 2013-04-25 16:20:59 PDT
(In reply to comment #0)
> Currently triggering assertions, not sure if they're just wrong, or if i have other issues

How to repro the assertions?
Comment 4 Filip Pizlo 2013-04-25 16:24:10 PDT
(In reply to comment #3)
> (In reply to comment #0)
> > Currently triggering assertions, not sure if they're just wrong, or if i have other issues
> 
> How to repro the assertions?

Never mind.
Comment 5 Filip Pizlo 2013-04-25 16:29:57 PDT
Created attachment 199763 [details]
the patch
Comment 6 WebKit Commit Bot 2013-04-25 16:32:23 PDT
Attachment 199763 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp', u'Source/JavaScriptCore/dfg/DFGCapabilities.h', u'Source/JavaScriptCore/dfg/DFGFixupPhase.cpp', u'Source/JavaScriptCore/dfg/DFGNodeFlags.h', u'Source/JavaScriptCore/dfg/DFGNodeType.h', u'Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp']" exit_code: 1
Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:798:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Filip Pizlo 2013-04-25 16:39:50 PDT
I'll run it on this: http://kripken.github.io/ammo.js/examples/new/ammo.html
Comment 8 Geoffrey Garen 2013-04-25 16:55:56 PDT
Comment on attachment 199763 [details]
the patch

r=me
Comment 9 Filip Pizlo 2013-04-25 18:17:25 PDT
Landed in http://trac.webkit.org/changeset/149162