Bug 115123 - AX: aria-required is not exposed on all expected roles
Summary: AX: aria-required is not exposed on all expected roles
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: James Craig
URL:
Keywords: InRadar
Depends on:
Blocks: 117817 118364
  Show dependency tree / graph
 
Reported: 2013-04-24 13:45 PDT by James Craig
Modified: 2013-07-03 11:15 PDT (History)
9 users (show)

See Also:

Attachments
patch (8.59 KB, patch)
2013-06-19 02:51 PDT, James Craig 		no flags Details | Formatted Diff | Diff
patch (8.63 KB, patch)
2013-06-19 03:03 PDT, James Craig 		cfleizach: review-
Details | Formatted Diff | Diff
patch (11.75 KB, patch)
2013-06-19 20:13 PDT, James Craig 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Radar WebKit Bug Importer 2013-04-24 13:45:50 PDT 
<rdar://problem/13730458>
Comment 4 James Craig 2013-04-24 23:12:40 PDT 
Test case #3, spinbutton (AXStepper)

https://dvcs.w3.org/hg/pfwg/raw-file/default/ARIA/1.0/tests/test-files/roles-properties-supported/roles-properties-supported-spinbutton-aria-required-true.html

Here's the list of roles where aria-required is supported:

combobox
columnheader
gridcell
listbox
radiogroup
rowheader
spinbutton
textbox
tree
treegrid
Comment 5 James Craig 2013-04-24 23:13:57 PDT 
s/AXStepper/AXIncrementor/ (Note: VO calls it "stepper")
Comment 6 James Craig 2013-06-19 02:51:22 PDT 
Created attachment 204979 [details]
patch
Comment 7 James Craig 2013-06-19 03:03:38 PDT 
Created attachment 204981 [details]
patch
Comment 8 chris fleizach 2013-06-19 11:15:03 PDT 
Comment on attachment 204981 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204981&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1023
> +    // required attr exposed on various HTML elements...

These lines should be in the form of sentences.

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1033
> +        || m_object->isTree()

We should move this logic into a method like, supportsRequiredAttribute()
We should also switch to using a switch statement on the role which will be baster

switch (roleValue()) {
  case ComboBox:
  case Tree:
     ….
}
Comment 9 James Craig 2013-06-19 20:13:32 PDT 
Created attachment 205050 [details]
patch
Comment 10 WebKit Commit Bot 2013-06-20 09:08:30 PDT 
Comment on attachment 205050 [details]
patch

Clearing flags on attachment: 205050

Committed r151776: <http://trac.webkit.org/changeset/151776>
Comment 11 WebKit Commit Bot 2013-06-20 09:08:33 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 12 James Craig 2013-07-03 11:15:22 PDT 
Follow-on work for tables/grid will be in bug 118364.