Bug 115118 – [GTK] Use stamp files for generate-forwarding-headers makefile rules

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Carlos Garcia Campos]

We are currently running the generate-forwarding-headers.pl script 6 times everytime we run make even if nothing has changed. This is because the makefile rules that call the script don't create a file that can be checked to decide whether to run the rule or not.

[Carlos Garcia Campos]

Created attachment 199499 [details]
Patch

[Martin Robinson]

Comment on attachment 199499 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199499&action=review

Looks good. I just have one question...

> Source/WebKit2/GNUmakefile.am:326
>  BUILT_SOURCES += generate-webkit2-forwarding-headers

Would it make more sense to add the stamp files to BUILT_SOURCES now?

> Tools/TestWebKitAPI/GNUmakefile.am:229
> +wk2_tests_sources = $(Programs_TestWebKitAPI_TestWebKit2_SOURCES) $(Libraries_libTestWebKitAPIInjectedBundle_la_SOURCES)

I don't think there's any need for this intermediate variable, unless it's used somewhere else.

[Carlos Garcia Campos]

(In reply to comment #2)
> (From update of attachment 199499 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=199499&action=review
> 
> Looks good. I just have one question...
> 
> > Source/WebKit2/GNUmakefile.am:326
> >  BUILT_SOURCES += generate-webkit2-forwarding-headers
> 
> Would it make more sense to add the stamp files to BUILT_SOURCES now?

hmm, I think you are right, and we don't need to add them to cleanfiles either since all built source are already in cleanfiles. Let me try.

> > Tools/TestWebKitAPI/GNUmakefile.am:229
> > +wk2_tests_sources = $(Programs_TestWebKitAPI_TestWebKit2_SOURCES) $(Libraries_libTestWebKitAPIInjectedBundle_la_SOURCES)
> 
> I don't think there's any need for this intermediate variable, unless it's used somewhere else.

It makes the rule easier to read, that's all.

[Carlos Garcia Campos]

Created attachment 199505 [details]
Updated patch

Removed intermediate rules

[Martin Robinson]

Comment on attachment 199505 [details]
Updated patch

Thanks!

[Carlos Garcia Campos]

Committed r149052: <http://trac.webkit.org/changeset/149052>