Bug 115115 - 85 inspector tests asserting in DrawingAreaProxyImpl::updateAcceleratedCompositingMode() when there is a stale WebKitTestRunner preference
Summary: 85 inspector tests asserting in DrawingAreaProxyImpl::updateAcceleratedCompos...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-24 09:50 PDT by Simon Fraser (smfr)
Modified: 2013-10-30 16:41 PDT (History)
5 users (show)

See Also:

Attachments
proposed fix (9.07 KB, patch)
2013-10-30 12:45 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2013-04-24 09:50:57 PDT 
Lots of insepctor tests are asserting on the WK2 bot after http://trac.webkit.org/changeset/149006
Comment 1 Simon Fraser (smfr) 2013-04-24 09:51:40 PDT 
DrawingAreaImpl 0x7f8844a2df10 updateAcceleratedCompositingMode backingStoreStateID=1 m_currentBackingStoreStateID=0
ARGUMENT BAD: backingStoreStateID, backingStoreStateID <= m_currentBackingStoreStateID
Comment 2 Simon Fraser (smfr) 2013-04-24 14:03:03 PDT 
I worked around this by nuking the on-disk prefs that specified that the inspector should use accelerated drawing.
Comment 3 Alexey Proskuryakov 2013-08-31 22:51:32 PDT 
defaults delete WebKitTestRunner

We need to do something about ever using persistent preferences in WKTR.
Comment 4 Simon Fraser (smfr) 2013-09-03 11:12:23 PDT 
Perhaps the scripts should do 'defaults delete WebKitTestRunner' each time?
Comment 5 Alexey Proskuryakov 2013-10-30 01:10:38 PDT 
Doing that in bug 29751.
Comment 6 Alexey Proskuryakov 2013-10-30 12:45:36 PDT 
Created attachment 215552 [details]
proposed fix

Actually no, doing it here.
Comment 7 WebKit Commit Bot 2013-10-30 16:41:24 PDT 
Comment on attachment 215552 [details]
proposed fix

Clearing flags on attachment: 215552

Committed r158326: <http://trac.webkit.org/changeset/158326>
Comment 8 WebKit Commit Bot 2013-10-30 16:41:26 PDT 
All reviewed patches have been landed.  Closing bug.