Bug 115114 - ref-tests should compare the entire page instead of the viewport
Summary: ref-tests should compare the entire page instead of the viewport
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-24 09:36 PDT by Zoltan Horvath
Modified: 2013-04-24 13:24 PDT (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2013-04-24 09:36:10 PDT
The topic was discussed in https://lists.webkit.org/pipermail/webkit-dev/2013-April/024766.html
Comment 1 Glenn Adams 2013-04-24 12:51:45 PDT
if existing reftests assume that only a particular (e.g., 800x600) area is compared, then we should not change the default to compare the entire page; that is, comparing the entire page should be opt-in due to prior usage
Comment 2 Ryosuke Niwa 2013-04-24 13:05:39 PDT
(In reply to comment #1)
> if existing reftests assume that only a particular (e.g., 800x600) area is compared, then we should not change the default to compare the entire page; that is, comparing the entire page should be opt-in due to prior usage

We shouldn’t make such assumptions in reftests. If there are ref tests that make such a bad assumption, then we should fix them all.
Comment 3 Glenn Adams 2013-04-24 13:24:57 PDT
(In reply to comment #2)
> (In reply to comment #1)
> > if existing reftests assume that only a particular (e.g., 800x600) area is compared, then we should not change the default to compare the entire page; that is, comparing the entire page should be opt-in due to prior usage
> 
> We shouldn’t make such assumptions in reftests. If there are ref tests that make such a bad assumption, then we should fix them all.

ok, in that case, the documentations about creating reftests [1] should make this explicit; authors may have assumed that 800x600 holds due to the language in [2]

[1] http://trac.webkit.org/wiki/Writing%20Reftests
[2] http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree#Howtowriteportablepixeltests