NEW 115114
ref-tests should compare the entire page instead of the viewport 
https://bugs.webkit.org/show_bug.cgi?id=115114
Summary ref-tests should compare the entire page instead of the viewport
Zoltan Horvath
Reported 2013-04-24 09:36:10 PDT
The topic was discussed in https://lists.webkit.org/pipermail/webkit-dev/2013-April/024766.html
Attachments
Add attachment proposed patch, testcase, etc.
Glenn Adams
Comment 1 2013-04-24 12:51:45 PDT
if existing reftests assume that only a particular (e.g., 800x600) area is compared, then we should not change the default to compare the entire page; that is, comparing the entire page should be opt-in due to prior usage
Ryosuke Niwa
Comment 2 2013-04-24 13:05:39 PDT
(In reply to comment #1) > if existing reftests assume that only a particular (e.g., 800x600) area is compared, then we should not change the default to compare the entire page; that is, comparing the entire page should be opt-in due to prior usage We shouldn’t make such assumptions in reftests. If there are ref tests that make such a bad assumption, then we should fix them all.
Glenn Adams
Comment 3 2013-04-24 13:24:57 PDT
(In reply to comment #2) > (In reply to comment #1) > > if existing reftests assume that only a particular (e.g., 800x600) area is compared, then we should not change the default to compare the entire page; that is, comparing the entire page should be opt-in due to prior usage > > We shouldn’t make such assumptions in reftests. If there are ref tests that make such a bad assumption, then we should fix them all. ok, in that case, the documentations about creating reftests [1] should make this explicit; authors may have assumed that 800x600 holds due to the language in [2] [1] http://trac.webkit.org/wiki/Writing%20Reftests [2] http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree#Howtowriteportablepixeltests
Note You need to log in before you can comment on or make changes to this bug.