Bug 115112 – Build fix: WebKit2/WKView.h should not be included in WebKit2_C.h

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebKit EFL

[Adenilson Cavalcanti Silva]

Current trunk compilation will fail in Linux 64bits with:
//----------------------------------------------------------------------------------------------
[  6%] Building CXX object Tools/TestWebKitAPI/CMakeFiles/test_wtf.dir/Tests/WTF/IntegerToStringConversion.cpp.o
Building CXX object Tools/TestWebKitAPI/CMakeFiles/test_wtf.dir/Tests/WTF/HashMap.cpp.o
In file included from /home/adenilson/apps/webkit/Webkit/WebKitBuild/Debug/DerivedSources/WebKit2/include/WebKit2/WebKit2_C.h:1:0,
                 from /home/adenilson/apps/webkit/Webkit/Tools/TestWebKitAPI/config.h:72,
                 from /home/adenilson/apps/webkit/Webkit/Tools/TestWebKitAPI/TestsController.cpp:26:
/home/adenilson/apps/webkit/Webkit/Source/WebKit2/UIProcess/API/C/WebKit2_C.h:65:28: fatal error: WebKit2/WKView.h: No such file or directory
compilation terminated.
In file included from /home/adenilson/apps/webkit/Webkit/WebKitBuild/Debug/DerivedSources/WebKit2/include/WebKit2/WebKit2_C.h:1:0,
                 from /home/adenilson/apps/webkit/Webkit/Tools/TestWebKitAPI/config.h:72,
                 from /home/adenilson/apps/webkit/Webkit/Tools/TestWebKitAPI/Tests/WTF/AtomicString.cpp:26:
/home/adenilson/apps/webkit/Webkit/Source/WebKit2/UIProcess/API/C/WebKit2_C.h:65:28: fatal error: WebKit2/WKView.h: No such file or directory
compilation terminated.

//----------------------------------------------------------------------------------------------

[Adenilson Cavalcanti Silva]

Created attachment 199494 [details]
Build++

[EFL EWS Bot]

Comment on attachment 199494 [details]
Build++

Attachment 199494 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/168248

[Adenilson Cavalcanti Silva]

I see that this regression was introduced in changeset: http://trac.webkit.org/changeset/147776

My patch will make compilation pass from 6% but it will get stuck at 89%, with:
//-------------------------------------------------------------------
[ 89%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.cpp.o
In file included from /home/adenilson/apps/webkit/Webkit/Source/WebKit2/UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.cpp:33:0:
/home/adenilson/apps/webkit/Webkit/Source/WebKit2/UIProcess/CoordinatedGraphics/WKCoordinatedSceneAPICast.h:31:40: fatal error: WebKit2/WKCoordinatedScene.h: No such file or directory
compilation terminated.
make[2]: *** [Source/WebKit2/CMakeFiles/ewebkit2.dir/UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.cpp.o] Error 1
//-------------------------------------------------------------------

My suggestion would be to rollback the 147776 changeset and get it fixed first.

[Darin Adler]

Comment on attachment 199494 [details]
Build++

review- because the EFL bot says this doesn’t compile