Bug 115103 - ElementData should use 'unsigned' attribute indices.
Summary: ElementData should use 'unsigned' attribute indices.
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Depends on:
Reported: 2013-04-24 05:25 PDT by Andreas Kling
Modified: 2013-04-24 13:02 PDT (History)
6 users (show)

See Also:

Proposed patch (17.38 KB, patch)
2013-04-24 05:28 PDT, Andreas Kling
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-04-24 05:25:58 PDT
We should use 32-bit indices for element attributes, especially now that Vector is already limited to 32-bit capacity.
Comment 1 Andreas Kling 2013-04-24 05:28:20 PDT
Created attachment 199417 [details]
Proposed patch
Comment 2 Andreas Kling 2013-04-24 05:29:23 PDT
Oliver/Antti, what do you think about this? It seems to me like we want to minimize the amount of code that deals in size_t indices into arrays/vectors whose capacity is limited to 32 bits.
Comment 3 Antti Koivisto 2013-04-24 12:14:34 PDT
Comment on attachment 199417 [details]
Proposed patch

Sounds great to me.
Comment 4 Andreas Kling 2013-04-24 13:02:14 PDT
Committed r149061: <http://trac.webkit.org/changeset/149061>