Bug 115098 - [WebKit2] Add CoordinatedGraphics to the list of platforms in generate-forwarding-headers.pl
Summary: [WebKit2] Add CoordinatedGraphics to the list of platforms in generate-forwar...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2013-04-24 03:12 PDT by Carlos Garcia Campos
Modified: 2013-04-24 08:25 PDT (History)
3 users (show)

See Also:

Patch (1.67 KB, patch)
2013-04-24 03:15 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2013-04-24 03:12:02 PDT
r148963 introduced a new WKView.h header in a directory not listed as a platform prefix in generate-forwarding-headers.pl. This makes the header to be generated twice, and files depdening on it to be compiled again every time, see:

  GEN    generate-webkittestrunner-forwarding-headers
[Creating forwarding header for WebKit2/UIProcess/API/C/gtk/WKView.h]
  GEN    generate-testwebkitapi-forwarding-headers
[Creating forwarding header for WebKit2/UIProcess/API/C/CoordinatedGraphics/WKView.h]
[Creating forwarding header for WebKit2/UIProcess/API/C/gtk/WKView.h]
  GEN    generate-webkit2-forwarding-headers
[Creating forwarding header for WebKit2/UIProcess/API/C/CoordinatedGraphics/WKView.h]
Comment 1 Carlos Garcia Campos 2013-04-24 03:15:18 PDT
Created attachment 199408 [details]

Replace unused chromium with CoordinatedGraphics
Comment 2 WebKit Commit Bot 2013-04-24 08:25:16 PDT
Comment on attachment 199408 [details]

Clearing flags on attachment: 199408

Committed r149036: <http://trac.webkit.org/changeset/149036>
Comment 3 WebKit Commit Bot 2013-04-24 08:25:18 PDT
All reviewed patches have been landed.  Closing bug.