Bug 115092 - [BlackBerry] Remove the setContentsToColor flavor of LayerTiler::TextureJob
Summary: [BlackBerry] Remove the setContentsToColor flavor of LayerTiler::TextureJob
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Arvid Nilsson
Depends on:
Reported: 2013-04-24 00:25 PDT by Arvid Nilsson
Modified: 2013-04-24 01:08 PDT (History)
6 users (show)

See Also:

Patch (6.38 KB, patch)
2013-04-24 00:33 PDT, Arvid Nilsson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arvid Nilsson 2013-04-24 00:25:36 PDT
This is dead code that was used with the Skia backend, but no longer useful. With Skia, when we detected that a layer contained only solid color, we'd draw a 1x1 texture containing that color across the layer bounds. With the GL renderer, for solid color layers the display list will only contain commands to draw the solid color, so the optimization is "built in". This cleanup is done as part of PR 273550.

The WebOverlay still uses the TextureCacheCompositingThread::textureForColor() so that one can stay for now.
Comment 1 Arvid Nilsson 2013-04-24 00:33:44 PDT
Created attachment 199399 [details]
Comment 2 Arvid Nilsson 2013-04-24 00:41:51 PDT
Comment on attachment 199399 [details]

Thanks cgarcia =)
Comment 3 WebKit Commit Bot 2013-04-24 01:08:50 PDT
Comment on attachment 199399 [details]

Clearing flags on attachment: 199399

Committed r149019: <http://trac.webkit.org/changeset/149019>
Comment 4 WebKit Commit Bot 2013-04-24 01:08:52 PDT
All reviewed patches have been landed.  Closing bug.