Bug 115089 - Function parameter quotePair can be passed by reference
Summary: Function parameter quotePair can be passed by reference
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kangil Han
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-23 22:57 PDT by Kangil Han
Modified: 2013-04-24 17:43 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.01 KB, patch)
2013-04-23 22:59 PDT, Kangil Han
no flags Details | Formatted Diff | Diff
Patch (2.04 KB, patch)
2013-04-24 17:15 PDT, Kangil Han
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kangil Han 2013-04-23 22:57:08 PDT
Function parameter quotePair can be passed by reference
Comment 1 Kangil Han 2013-04-23 22:59:53 PDT
Created attachment 199388 [details]
Patch
Comment 2 Alexey Proskuryakov 2013-04-24 09:02:55 PDT
Comment on attachment 199388 [details]
Patch

r=me

I don't think that "[Minor code refactoring]" is a useful prefix. We use bracketed prefixes for platform specific bugs/patches as a signal that most people can skip those.
Comment 3 Kangil Han 2013-04-24 17:15:39 PDT
Created attachment 199538 [details]
Patch
Comment 4 Kangil Han 2013-04-24 17:16:21 PDT
(In reply to comment #2)
> I don't think that "[Minor code refactoring]" is a useful prefix. We use bracketed prefixes for platform specific bugs/patches as a signal that most people can skip those.

Done. :)
Comment 5 WebKit Commit Bot 2013-04-24 17:43:09 PDT
Comment on attachment 199538 [details]
Patch

Clearing flags on attachment: 199538

Committed r149080: <http://trac.webkit.org/changeset/149080>
Comment 6 WebKit Commit Bot 2013-04-24 17:43:10 PDT
All reviewed patches have been landed.  Closing bug.